Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack] Avoid duplicate id entries #59

Open
beefchimi opened this issue Jan 15, 2024 · 0 comments
Open

[Stack] Avoid duplicate id entries #59

beefchimi opened this issue Jan 15, 2024 · 0 comments
Labels
🐛 Bug Something isn't working

Comments

@beefchimi
Copy link
Owner

The .prepare() method allows an optional id. However, we are not checking to see if that id already exists within the Stack.

What should we do?

  • Do not add the new Sound (early return)?
  • Detect a duplicate and force a unique id on the new Sound?
  • Accept the new incoming Sound AFTER calling .stop() and removing the previous matching id?
@beefchimi beefchimi added the 🐛 Bug Something isn't working label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beefchimi