Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Locale] Figure out how to handle multi-region URLs #29

Open
beefchimi opened this issue Jan 19, 2022 · 0 comments
Open

[Locale] Figure out how to handle multi-region URLs #29

beefchimi opened this issue Jan 19, 2022 · 0 comments
Labels
✨ Feature New addition to the codebase (feature, utility, component, etc.) 🧑‍💻 Help wanted Extra attention is needed

Comments

@beefchimi
Copy link
Owner

We are going to have some cases where our capturing logic breaks because of how the URL changes for different regions.

Take YouTube Brazil for example: https://youtube.com.br/xyz is apparently the URL structure. Our current youtube capturing will simply break... because com will be the domain value.

We will need a way to specify how to target locale per network, since every network may implement this differently.

Furthermore, we will need a way to generate the preferredUrl based on locale.

We need to start by making a list of all of these differing multi-region URLs.

@beefchimi beefchimi added ✨ Feature New addition to the codebase (feature, utility, component, etc.) 🧑‍💻 Help wanted Extra attention is needed labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature New addition to the codebase (feature, utility, component, etc.) 🧑‍💻 Help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant