Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] Incorrectly allowing any key/value pair on a typed object #9

Open
beefchimi opened this issue Jan 16, 2022 · 0 comments
Open
Labels
🐛 Bug Something isn't working

Comments

@beefchimi
Copy link
Owner

While using reduce(), TypeScript is allowing me to add any key/value pair to the object:

export function filterNetworkProperties(
  network: SocialNetwork,
  subset: SocialNetworkProperties,
) {
  const uniqueProperties: SocialNetworkProperties = [...new Set(subset)];
  const keys = Object.keys(network) as SocialNetworkProperties;

  return uniqueProperties.length
    ? keys.reduce<SocialNetworkSubset>(
        (filtered, property) =>
          uniqueProperties.includes(property)
            ? {
                ...filtered,
                [property]: network[property],
                // BUG: This should not be allowed!
                foo: 'bar',
              }
            : filtered,
        {} as SocialNetworkSubset,
      )
    : network;
}
@beefchimi beefchimi added the 🐛 Bug Something isn't working label Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant