-
|
Hi, I'm struggling with how to configure TaskGraph for this to work properly. In the first execution everything works fine, the problem is with the next ones. I already tries to replace parameters before executing but it did not fix the problem. The parameter results and updatedMark will be modified during the execution. When I inspect this two parameters they are correct, the values are as expect after "morpheus.execute();". Then I update mark, and replace the parameters end execute again, but nothing happens. Can you hepl me please? Could it be because I have this? The "if" is messing this? Thank you for your help with this, |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 20 replies
-
|
Hi @MLobatoR, the use of the In a nutshell, the TaskGraph should be converted to an And then an Finally, you can execute: |
Beta Was this translation helpful? Give feedback.
-
|
Hi @MLobatoR , we recently upgraded the maven version and other dependencies. Are you using the latest version from the |
Beta Was this translation helpful? Give feedback.
-
|
Hi @jjfumero, I followed the instruction on readthedocs. There you have the following: So I suppose this is the latest version available. |
Beta Was this translation helpful? Give feedback.
-
|
I just checked on Windows 11 and MSys64. It works for me. If it helps, this is my $ cat sources.sh
#!/bin/bash
# UPDATE PATH TO ACTUAL LOCATION OF THE JDK OR GRAAL (REMEMBER OF UNIX_STYLE SLASHES AND SPACES!!!)
export JAVA_HOME="C:\Users\jjfum\Documents\bin\jvms\graalvm-ce-java17-windows-amd64-22.3.2\graalvm-ce-java17-22.3.2"
## NEXT TWO LINES NECESSARY TO BUILD PTX (NVIDIA CUDA) BACKEND
## COMMENT THEM OUT OR JUST IGNORE IF YOU ARE NOT INTERESTED IN PTX BUILD
## OTHERWISE UPDATE 'CUDA_PATH' WITH ACTUAL VALUE (REMEMBER OF UNIX_STYLE SLASHES AND SPACES!!!)
export CUDA_PATH="C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.6"
export PTX_LDFLAGS=-L\"$CUDA_PATH/lib/x64\"
# LEAVE THE REST OF FILE 'AS IS'
# DON'T ALTER!
export PATH=$PWD/bin/bin:$PATH ## This directory will be automatically generated during Tornado compilation
export TORNADO_SDK=$PWD/bin/sdk ## This directory will be automatically generated during Tornado compilation
CMAKE_FILE=$(where cmake | head -n 1)
export CMAKE_ROOT=${CMAKE_FILE%\\*\\*}Then I just did: $ . sources.sh
$ make graal-jdk-11-plus
$ tornado --version
version=0.15.2-dev
branch=master
commit=5a93a7c
Backends installed:
- opencl
$ tornado --devices
Number of Tornado drivers: 1
Driver: OpenCL
Total number of OpenCL devices : 4
Tornado device=0:0 (DEFAULT)
OPENCL -- [Intel(R) OpenCL HD Graphics] -- Intel(R) UHD Graphics 770
Global Memory Size: 12.7 GB
Local Memory Size: 64.0 KB
Workgroup Dimensions: 3
Total Number of Block Threads: [256]
Max WorkGroup Configuration: [256, 256, 256]
Device OpenCL C version: OpenCL C 1.2
Tornado device=0:1
OPENCL -- [NVIDIA CUDA] -- NVIDIA GeForce RTX 3070
Global Memory Size: 8.0 GB
Local Memory Size: 48.0 KB
Workgroup Dimensions: 3
Total Number of Block Threads: [1024]
Max WorkGroup Configuration: [1024, 1024, 64]
Device OpenCL C version: OpenCL C 1.2
Tornado device=0:2
OPENCL -- [Intel(R) OpenCL] -- 12th Gen Intel(R) Core(TM) i7-12700K
Global Memory Size: 31.7 GB
Local Memory Size: 32.0 KB
Workgroup Dimensions: 3
Total Number of Block Threads: [8192]
Max WorkGroup Configuration: [8192, 8192, 8192]
Device OpenCL C version: OpenCL C 3.0
Tornado device=0:3
OPENCL -- [Intel(R) FPGA Emulation Platform for OpenCL(TM)] -- Intel(R) FPGA Emulation Device
Global Memory Size: 31.7 GB
Local Memory Size: 256.0 KB
Workgroup Dimensions: 3
Total Number of Block Threads: [67108864]
Max WorkGroup Configuration: [67108864, 67108864, 67108864]
Device OpenCL C version: OpenCL C 1.2 |
Beta Was this translation helpful? Give feedback.
-
|
Thank you, it worked. If I run test on cmd window they are successful. But I need a little bit more help, please. I'm running Matrix multiplication on Eclipse IDE. And I'm getting this error: I already added the arguments to VM, but nothing seems to work. Do I need to add some specific libraries somewhere? Thank you in advance for all your help |
Beta Was this translation helpful? Give feedback.
-
|
I found out the problem. It is working now. Now I will check if with the code updated the original problem is fixed. I'll send you some feedback later. Thank you |
Beta Was this translation helpful? Give feedback.
-
|
I don't understand what is the function that replaces "replaceParameter" of TaskGraph. This was running multiple times and every time it was running I was doing this and it was working fine: But now the results are not being updated and I think is because I'm not replacing old parameters with the new ones. Thank you, |
Beta Was this translation helpful? Give feedback.
-
|
Sorry. wrong repo. This should be the one: https://github.com/beehive-lab/TornadoVM/blob/master/tornado-unittests/src/main/java/uk/ac/manchester/tornado/unittests/executor/TestExecutor.java#L186-L235 |
Beta Was this translation helpful? Give feedback.
-
|
I don't think this is what I need. Depending in the result, some other variable will change their value. I was using replace parameter precisely to do that. I don't want to instantiate multiple task graphs, at least in the earliest version i didn't need to do that. I just replaced the parameters in every iteration. Here's the code as it was in previous version, and it was working fine: Can you help me comprehend what to do to use the latest version in order for this to work properly please? Because if I remove replace parameters and add the ImmutableTaskGraph this stops working and I don't understand how to make this work again in the latest version. Thank you, |
Beta Was this translation helpful? Give feedback.
-
|
Hi @MLobatoR . In the previous version, every time we invoke Thus. we introduced the TornadoExecutionPlan and we split the task-graph into two parts: You can define different task graphs associated with different sets of data and pass data around these graphs through different execution plans (as we show in the unit test). You can find more details in our documentation: https://tornadovm.readthedocs.io/en/latest/programming.html We had a similar use case to yours in our Quantum Compute Simulator with TornadoVM:
In this case, data is copied from the host side using System.arraycopy: A side note: we are improving TornadoVM with new types to avoid extra copies between Java heap <-> native memory. Thus, in the near future, this part will be also optimized. |
Beta Was this translation helpful? Give feedback.
-
|
We also have documented how to transition from the previous API to the new Execution Plan: |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for all your help. I'll try using what you suggested. ML |
Beta Was this translation helpful? Give feedback.
-
|
Hi @jjfumero, Followinh your suggestion I updated my code. Now I get this warning when transfer data to host: The object I'm trying to transfer is int[][], nothing special, in my opinion. Because I'm ignoring this warning when I execute I have an error. My question is what are the objects you support on transfer to host. The examples I saw where float[]. What can I do here? Thank you in advance for your help, |
Beta Was this translation helpful? Give feedback.
-
|
Hi @MLobatoR . We have examples in the unit-tests and in the example module of TornadoVM:
|
Beta Was this translation helpful? Give feedback.
-
|
@jjfumero if I use those and I'm not able to use replace parameter anymore, how I'm supposed to follow your previous suggestion and use System.arraycopy to replace some parameters? Thank you, |
Beta Was this translation helpful? Give feedback.
-
|
The If this approach does not fit your needs, feel free to create a simple test-case, and send us a proposal with the feature/s you would like to add in TornadoVM. It is important to understand why your use case could not use multiple execution plans instead, and how we could approach your patterns/examples. The way to open proposals is via GitHub discussions. |
Beta Was this translation helpful? Give feedback.
-
|
@jjfumero it is working fine, thank you for all your help :) |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the follow-up. I will close this issue. |
Beta Was this translation helpful? Give feedback.
The
replaceParametersmethod within the TaskSchedule was removed in version 0.15. We do not need this call because we can use multiple task-graphs and move data across them. I think you should create multiple task-graphs (as many as you need) and multiple execution plans. And move data around as we point out in the examples.If this approach does not fit your needs, feel free to create a simple test-case, and send us a proposal with the feature/s you would like to add in TornadoVM. It is important to understand why your use case could not use multiple execution plans instead, and how we could approach your patterns/examples. The way to open proposals is via GitHub discussions.