Lyrics: Use distance threshold for Genius search matches #5453
+126
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snejus
force-pushed
the
lyrics-fix-genius-artist-matching
branch
4 times, most recently
from
adc2d20
to
ad04330
Compare
|
Have just discovered that it is not anymore possible to search lyrics on Tekstowo since search results are now shown within a Google container which is not parseable. |
|
Going to move the last commit with tekstowo change to a separate PR and handle this issue there. |
snejus
force-pushed
the
lyrics-fix-genius-artist-matching
branch
from
ad04330
to
f479cfa
Compare
snejus
force-pushed
the
lyrics-fix-genius-artist-matching
branch
from
f479cfa
to
f305c89
Compare
This commit introduces a distance threshold mechanism for the Genius and Google backends. - Create a new `SearchBackend` base class with a method `check_match` that performs checking. - Start using undocumented `dist_thresh` configuration option for good, and mention it in the docs. This controls the maximum allowable distance for matching artist and title names. These changes aim to improve the accuracy of lyrics matching, especially when there are slight variations in artist or title names, see #4791.
snejus
force-pushed
the
lyrics-fix-genius-artist-matching
branch
from
f305c89
to
4bf1061
Compare
|
Superseded by #5474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a distance threshold mechanism to the Genius backend and unifies its implementation across the rest of backends that perform searching and matching artists and titles.
SearchBackendbase class with a methodcheck_matchthat performs matching.dist_threshconfiguration option for good, and mention it in the docs. This controls the maximum allowable distance for matching artist and title names.These changes aim to improve the accuracy of lyrics matching, especially when there are slight variations in artist or title names.
Fixes #4791
To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)