[WIP]: Enable Flex declarations #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
changed the title
|
Is it ok to enable all the flex props in this PR and add tests for all of them? or you prefer I split them in smaller PRs @freakboy3742 ? |
|
It's depends a bit on complexity. Broadly speaking, having one PR per "significant new validator/parser" is probably a good bet, unless they are really closely aligned. However, if it's just a matter of adding a bunch of declarations (which is really just a list of constants and rule definitions, not new "logic" per se), it's fine to dump all those into a single PR. |
goanpeca
force-pushed
the
enh/enable-flex-declaration
branch
from
a784f9f to
f36f298
Compare
|
I guess this is ok since these enables several simple declarations and adds two shorthand methods. Will add tests for those. Is it ok then to leave this as a single PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.