You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently all the 3 background color tests on the testbed cannot be enabled for all widgets, since there are problems associated with the widget background color on some platforms like on Android and Winforms. If we enable all 3 background color tests on every widget, then the testbed would pass on iOS, but would fail on other platforms. At the same time, we cannot correct their behavior to make them pass the tests as fixes for those platforms exist on separate PRs.
For example, If we enable all the 3 tests: test_background_color, test_background_color_reset, test_background_transparent on the Box widget then the tests would pass on iOS, but would fail on Winforms, since the fix for winforms exists on a separate PR.
Since behavioral changes need tests that confirms their behavior. So, to prevent a deadlock situation that would prevent this PR from being merged, I have created this issue to keep track of the widgets on which background color tests are not enabled. Since all 3 tests are enabled on most widgets so the list would be small. Afterwards, when all 3 dependent PRs are merged, we can enable all the 3 background color tests on all the widgets.
Current status:
test_background_color
test_background_color_reset
test_background_color_transparency
ActivityIndicator
Box
✅
✅
Button
✅
✅
✅
Canvas
✅
✅
✅
DateInput
✅
✅
✅
DetailedList
Divider
ImageView
✅
✅
✅
Label
✅
✅
✅
MapView
MultilineTextInput
✅
✅
✅
NumberInput
✅
✅
✅
OptionContainer
PasswordInput
✅
✅
✅
ProgressBar
ScrollContainer
✅
✅
✅
Selection
✅
✅
✅
Slider
SplitContainer
Switch
Table
✅
✅
TextInput
✅
✅
✅
TimeInput
✅
✅
✅
Tree
✅
✅
WebView
Additional context
Note: There are some widgets on which background color setting might not be relevant like on MapView or WebView. So, I will add more context for those widgets later.
The text was updated successfully, but these errors were encountered:
What is the problem or limitation you are having?
Related PRs: #3009, #2484
Context:
Currently all the 3 background color tests on the testbed cannot be enabled for all widgets, since there are problems associated with the widget background color on some platforms like on Android and Winforms. If we enable all 3 background color tests on every widget, then the testbed would pass on iOS, but would fail on other platforms. At the same time, we cannot correct their behavior to make them pass the tests as fixes for those platforms exist on separate PRs.
For example, If we enable all the 3 tests: test_background_color, test_background_color_reset, test_background_transparent on the Box widget then the tests would pass on iOS, but would fail on Winforms, since the fix for winforms exists on a separate PR.
Since behavioral changes need tests that confirms their behavior. So, to prevent a deadlock situation that would prevent this PR from being merged, I have created this issue to keep track of the widgets on which background color tests are not enabled. Since all 3 tests are enabled on most widgets so the list would be small. Afterwards, when all 3 dependent PRs are merged, we can enable all the 3 background color tests on all the widgets.
Current status:
ActivityIndicator
Box
Button
Canvas
DateInput
DetailedList
Divider
ImageView
Label
MapView
MultilineTextInput
NumberInput
OptionContainer
PasswordInput
ProgressBar
ScrollContainer
Selection
Slider
SplitContainer
Switch
Table
TextInput
TimeInput
Tree
WebView
Additional context
Note: There are some widgets on which background color setting might not be relevant like on
MapView
orWebView
. So, I will add more context for those widgets later.The text was updated successfully, but these errors were encountered: