Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - distribute analyzer config that disables conflicting rules #896

Open
belav opened this issue May 10, 2023 · 4 comments
Open

Feature - distribute analyzer config that disables conflicting rules #896

belav opened this issue May 10, 2023 · 4 comments

Comments

@belav
Copy link
Owner

belav commented May 10, 2023

There are some analyzers that conflict with csharpier, it appears that it is possible to distribute a config via a nuget package that would disable them.

This talks about the approach, and calls out that .net needs more support for global analyzer configs
https://devzone.channeladam.com/notebooks/languages/dotnet/editorconfig-distribution/

This indicates that the needed support is available
dotnet/roslyn#49834

@Meligy
Copy link

Meligy commented Jun 6, 2023

I'd love for the dotnet format part of this page to disappear, yes, please.

https://csharpier.com/docs/IntegratingWithLinters

It would make CSharpier a lot more smoother of an experience.

@Meligy
Copy link

Meligy commented Jun 6, 2023

Although another alternative might be #781

@belav
Copy link
Owner Author

belav commented Jun 8, 2023

Can you elaborate on why that portion of the page should disappear? It was a common question early on. I feel like it just needs to be expanded upon to call out any analyzers that may not play nice with csharpiers formatting.

@Meligy
Copy link

Meligy commented Jun 8, 2023

I meant that the tool does this by itself, that the user is not even faced by the problem at all, and hence does not need to worry about fixing it in user code.

If the library solves the compatibility issues like the suggestion in #781, or silently disables the conflicting issues by itself without asking the user to, which I understand is what #896 does, then no need to get the user to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants