Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nondeterministic output in make small-test #183

Closed
mernst opened this issue Aug 8, 2023 · 2 comments · Fixed by #184
Closed

Nondeterministic output in make small-test #183

mernst opened this issue Aug 8, 2023 · 2 comments · Fixed by #184
Assignees

Comments

@mernst
Copy link
Collaborator

mernst commented Aug 8, 2023

The valid_repos.csv and local_repos.csv files should be sorted, for determinism.
Or maybe they should only be sorted in the context of the make small-test test.

@benedikt-schesch
Copy link
Owner

I can sort them, but the output should currently be fully deterministic at the moment. Ordering is maintained at all times, even though it is shuffled (deterministically) in local_repos.csv.

@benedikt-schesch benedikt-schesch linked a pull request Aug 8, 2023 that will close this issue
@mernst
Copy link
Collaborator Author

mernst commented Aug 9, 2023

When I add a project, the order changes and so I have to run make small-test twice before it will pass locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants