Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support multiple filters added via bindings with repeat key presses toggling the filter #19

Open
benelan opened this issue May 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@benelan
Copy link
Owner

benelan commented May 18, 2024

Description

Only one filter can be applied at a time, and adding another removes the first. Filters should be stackable like they are on GitHub.

Acceptance Criteria

  1. Adding additional filters do not remove the ones already applied
  2. The bindings toggle filters on/off with multiple key presses

Relevant Info

With the scripts current design, this will likely require saving state to the filesystem, or potentially environment variables.

gh-fzf is getting too complicated for a shell script, so I'm considering a go rewrite using one of these libraries:

Example Use Case

  1. run gh fzf issue
  2. press alt-a to show the issues or pull requests assigned to you
  3. press alt-s to show both open and closed issues
  4. notice the assignee filter was removed

The current workaround is to start gh-fzf with one of the filters, e.g.

gh fzf issue --assignee @me
@benelan benelan added the enhancement New feature or request label May 18, 2024
@benelan benelan self-assigned this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant