Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Guice 3.0 #5

Open
qeishay opened this issue Mar 19, 2012 · 6 comments
Open

Upgrade to Guice 3.0 #5

qeishay opened this issue Mar 19, 2012 · 6 comments

Comments

@qeishay
Copy link

qeishay commented Mar 19, 2012

Any plans to upgrade to Guice 3.0?

@tsuckow
Copy link

tsuckow commented Mar 19, 2012

I am working on this now on my fork, hope to have it working later today or tomorrow. End of next week at the latest.

@qeishay
Copy link
Author

qeishay commented Mar 19, 2012

Thanks!

@tsuckow
Copy link

tsuckow commented Mar 20, 2012

Ok, I think it works. Let me know if there is anything you think should be changed/added.
Note: This is bleeding edge, I just completed it & there is bound to be bugs.

You can use this job as a maven repo: Repository
"uk.me.lings" % "scala-guice_2.9.1" % "3.0.1-SNAPSHOT"

Repo:
https://github.com/Deathbobomega/scala-guice/tree/guice3-port

Build Server:
http://ci.codingwell.net/job/Scala-Guice3/

@tsuckow
Copy link

tsuckow commented Mar 22, 2012

Ben,
I am going through and looking over everything. It seems like the "ScalaModule" and "BindingsExtensions" share a lot in common but expose a different API. Is there a reason for this or would it be better for me to unify them?

@ijuma
Copy link

ijuma commented May 10, 2012

Are there plans to integrate these changes?

nbauernfeind referenced this issue in nbauernfeind/scala-guice Dec 15, 2012
@nbauernfeind
Copy link

You can ignore that referenced issue; github did the wrong thing for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants