Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popover placement not working correctly #191

Open
vinaykevadia opened this issue Feb 21, 2019 · 2 comments
Open

popover placement not working correctly #191

vinaykevadia opened this issue Feb 21, 2019 · 2 comments

Comments

@vinaykevadia
Copy link

I am using the exact versions of the following:

  • Browser: [Chome|Firefox|IE|Safari] Version: 72.0.3626.109 Windows
  • AngularJS: 1.5.11
  • Angular Bootstrap: i don't see Angular Bootstrap installed as dependancy
  • Angular UI Tour: 0.9.4

I have installed this library via: (NPM, Bower, or downloaded package)
via Bower
I have observed the following behavior:
Popover positions are wrong
image

This is how I expected it to behave:
When i resize the windows, positions are getting correct.
image

Here is my tour config, and all related step configs:
TourConfigProvider.enableNavigationInterceptors();

var tourConfig = {};
ui-tour="chapter-sidebar-tour" ui-tour-backdrop="true"
<tour-step tour-step-title="..."
                         tour-step-content="..."
                         tour-step-order="0"
                         tour-step-placement="right">

Additional notes/code:

@sylvainbx
Copy link

I have the exact same behavior here with angular-ui-tour 0.9.4 and angularJS 1.7, installed through yarn. Have you found any workaround since then?

@sylvainbx
Copy link

After some investigations, #185 fixes the issue for me. As this PR was not merged for 2 years (and will probably never be), I managed to use this repository in my package.json

"dependencies": {
  "angular-ui-tour": "https://github.com/Ross-Byrne/angular-ui-tour.git#master",
}

and the issue went away :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants