Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid keeping reveal.js sources or submodule #301

Open
lucasrangit opened this issue Oct 27, 2021 · 1 comment
Open

Avoid keeping reveal.js sources or submodule #301

lucasrangit opened this issue Oct 27, 2021 · 1 comment
Assignees
@lucasrangit

Comments

@lucasrangit
Copy link
Member

Submodules are difficult to work with (since --recurse-submodule isn't default) and keeping external sources in our tree should be avoided.

Instead we should include this as a build dependency that gets downloaded only when needed.
@lucasrangit lucasrangit self-assigned this Oct 27, 2021
@lucasrangit lucasrangit mentioned this issue Oct 27, 2021
Merged
@lucasrangit
Copy link
Member Author

Or consider git subtree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasrangit lucasrangit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucasrangit