Fix collection display #610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating the output for a collection or checkbox using `display_as` or `display_with` the result is reformatted to match an option of the collection. After editing and selecting a different option, the output is rendered using the result from the display helper so the outputs differ from what's initially rendered and when an edit is made. This change only reformats the output to match a collection option when not using `display_as` or `display_with` so the behavior is consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the output for a collection or checkbox using
display_asor
display_withthe result is reformatted to match an option of thecollection. After editing and selecting a different option, the output
is rendered using the result from the display helper so the outputs differ
from what's initially rendered and when an edit is made. This change
only reformats the output to match a collection option when not using
display_asordisplay_withso the behavior is consistent.