Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods in microstructure module are long and confusing #79

Open
mpvanderschelling opened this issue Dec 6, 2023 · 0 comments
Open

Comments

@mpvanderschelling
Copy link

Problem

The functions to create the microstructures are really long. Although they have docstrings, the internal behaviour of the function is complicated and not easy to follow.

Proposed solution

Consider splitting the long methods into smaller methods that do separate things. You can document these smaller methods better and the 'main' method that ties everything together will be more readible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant