Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Dependency on old version of doctrine/annotations #102

Open
ygarris-sevensenders opened this issue Feb 1, 2023 · 2 comments · May be fixed by #105
Open

Dependency on old version of doctrine/annotations #102

ygarris-sevensenders opened this issue Feb 1, 2023 · 2 comments · May be fixed by #105

Comments

@ygarris-sevensenders
Copy link

Version 4.3.0 is dependent on doctrine/annotations of version ^1.7
It's very old version, and having flagseption/flagseption-bundle in composer.json prevents updating of doctrine/annotations to version 2 of which is required by some other packages, and therefore prevents updating of other packages.

Could you please update requirements in composer.json, so it will be like

   "doctrine/annotations": "^2.0",

Thank you!
@Chris53897
Copy link

I think there are better ways to solve this.
a) support both "doctrine/annotations": "^1.7 | | ^2.0",
b) Move the dependency to suggested and use PHP8 Attributes or Annotation (if supported). This is a BC change.
PR for PHP8 Attributes Support

@Chris53897
Copy link

I did a testrun https://github.com/Chris53897/flagception-bundle/actions/runs/4177313744 with "doctrine/annotations": "^1.7 | | ^2.0",
According to tests it will work without any code changes.
But i would recommend to test it on an real project ro be sure.

@ndench ndench linked a pull request May 25, 2023 that will close this issue
Open
@migo315 migo315 mentioned this issue Aug 22, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for doctrine/annotations 2.0 hyraiq/flagception-bundle
2 participants
@Chris53897 @ygarris-sevensenders