From 31efca3e9c2982fc86298ad3d749409199689ce5 Mon Sep 17 00:00:00 2001 From: bunnie Date: Wed, 31 Jan 2024 04:16:05 +0800 Subject: [PATCH] add fixme notes for where the Scalar was decomposed due to hash api incompatibility --- services/root-keys/src/implementation.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/services/root-keys/src/implementation.rs b/services/root-keys/src/implementation.rs index 774ad5fe8..8f0c933c6 100644 --- a/services/root-keys/src/implementation.rs +++ b/services/root-keys/src/implementation.rs @@ -2725,6 +2725,8 @@ impl<'a> RootKeys { pb }); + // FIXME: this should turn back into a Scalar-from-hash routine when Ed25519 gets API-bumped to be + // compatible with the hasher let mut output = [0u8; 64]; output.copy_from_slice(hasher.finalize().as_slice()); let r = Scalar::from_bytes_mod_order_wide(&output); @@ -2767,6 +2769,8 @@ impl<'a> RootKeys { pb.increment_work(1); } + // FIXME: this should turn back into a Scalar-from-hash routine when Ed25519 gets API-bumped to be + // compatible with the hasher let mut output = [0u8; 64]; output.copy_from_slice(hasher.finalize().as_slice()); let k = Scalar::from_bytes_mod_order_wide(&output);