Use PR number for matching commits to PRs in release/guide generator #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
I've removed the date range filter for the PRs in #1850. We may be able to do a smarter lookup than "fetch all of the PRs", but these two PRs together should be reliable.
alice-i-cecile
added
A-Build-System
C-Automation
|
Merging in concert with #1850. There's no user-facing impact here, and this is clearly better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially
fixes#1851I think there still may be a bit of a mismatch because we only fetch PRs from a particular date range, or whatever. But this should at least help with the renamed PRs.