Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop excessive data in test files #11

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Drop excessive data in test files #11

merged 2 commits into from
Jan 31, 2024

Conversation

bevzzz
Copy link
Owner

@bevzzz bevzzz commented Jan 31, 2024

  1. Fixed incorrect installation guide in the README for example/nbee
  2. Deleted base64-encoded image data from test / example notebooks and updated "golden" files:
    2.1. example/nbee/notebook.ipynb had 2 base64 images and weighted a whopping 273 KB. That's a lot of useless data to move around, considering that nbee is just an example for documentation purposes.
    2.2.. testdata/notebook.ipynb had 1 base64 image, which took up ~85% of its size -- that that image is part of the golden-file test is not essential, as rendering of images from a mime-bundle is well-tested in other unit tests
    2.3. Finally, because of so much .ipynb kilobytes, Github would assume nb was a predominantly-Jupyter-notebook-project, which is just not right :)

* Deleted the redundant notebook.ipynb, as there's already one in testdata/
Base64 image accounts for roughly 85% of the entire file size (~70Kb)
@bevzzz bevzzz merged commit 40a335d into main Jan 31, 2024
1 check passed
@bevzzz bevzzz deleted the example/nbee branch January 31, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant