Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example/nbee
2.1.
example/nbee/notebook.ipynb
had 2 base64 images and weighted a whopping 273 KB. That's a lot of useless data to move around, considering thatnbee
is just an example for documentation purposes.2.2..
testdata/notebook.ipynb
had 1 base64 image, which took up ~85% of its size -- that that image is part of the golden-file test is not essential, as rendering of images from a mime-bundle is well-tested in other unit tests2.3. Finally, because of so much
.ipynb
kilobytes, Github would assumenb
was a predominantly-Jupyter-notebook-project, which is just not right :)