Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/performance boost #224

Merged
merged 21 commits into from
Sep 16, 2023
Merged

Feature/performance boost #224

merged 21 commits into from
Sep 16, 2023

Conversation

bezhanSalleh
Copy link
Owner

closes #200

there is still a bug which in edit mode with bulktoggleable, didn't have time to figure it out.
don't know if it's my doing or filament/livewire issue.

@bezhanSalleh
Copy link
Owner Author

gif

BUG

Screen.Recording.2023-08-25.at.5.18.48.AM.mov

@bezhanSalleh
Copy link
Owner Author

should be merged and released when
filamentphp/filament#8061 PR is merged and released in filament v3

@bezhanSalleh bezhanSalleh marked this pull request as ready for review August 25, 2023 04:52
@bezhanSalleh bezhanSalleh marked this pull request as draft August 25, 2023 05:19
@bezhanSalleh bezhanSalleh marked this pull request as ready for review August 26, 2023 23:08
@Shipu
Copy link

Shipu commented Sep 2, 2023

Your filament v3 PR is merged. you merge this pull request

@bezhanSalleh
Copy link
Owner Author

Your filament v3 PR is merged. you merge this pull request

that fixes one issue, but there is bug in the afterStateUpdated() lifecycle hook of the CheckboxList component, which i didn't have time to figure out. fixed it for v2 but for v3 using a workaround.

will be releaseing it this weekend hopefully! for both shield v2 and v3

closes #204

@bezhanSalleh bezhanSalleh deleted the feature/performance-boost branch September 16, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants