From 94c3e37e96a5f1df8043914fd7fa7e2832b06e7f Mon Sep 17 00:00:00 2001
From: Stephan Robotta <stephan.robotta@bfh.ch>
Date: Wed, 4 Dec 2024 18:19:43 +0100
Subject: [PATCH] Remove criterion template header from upgrade, these have no
 connection to the vb instance.

---
 db/upgrade.php | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/db/upgrade.php b/db/upgrade.php
index d7e85c2..0f70678 100644
--- a/db/upgrade.php
+++ b/db/upgrade.php
@@ -155,12 +155,11 @@ function add_instance_to_localized_string() {
     foreach ($results as $result) {
         $DB->execute(
             sprintf('UPDATE {%s} SET instanceid = ?
-            WHERE foreignkey = ? AND typeid IN (?, ?)', tables::LOCALIZED_STRING_TABLE),
+            WHERE foreignkey = ? AND typeid = ?', tables::LOCALIZED_STRING_TABLE),
             [
                 $result->instanceid,
                 $result->id,
                 localized_string_type::str2id(localized_string_type::INSTANCE_CRITERION),
-                localized_string_type::str2id(localized_string_type::TEMPLATE_CRITERION),
             ]
         );
     }