-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data structure and logic updates #102
Open
Argeare5
wants to merge
90
commits into
main
Choose a base branch
from
feat/update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+34,473
−27,283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces significant improvements to our project, focusing on the elimination of the auxiliary library and a substantial reduction in RPC requests. Key changes include the integration of tRPC for the server version, a simplified Zustand store, and the removal of outdated caching mechanisms, allowing for the deprecation of related repositories and packages.
Additionally, the project structure has been updated to align with our UI standards, and the IPFS version has been reworked to enhance functionality. Notable performance improvements are evident in page speed metrics, with the new server version achieving higher scores and faster load times compared to the old version. Overall, these updates enhance user experience and developer efficiency.
In details:
Updated project structure (the structure matches all our UI projects).
Integrated tRPC for server version of the app.
Simplified
zustand
store.Removed all things related to old caching. ( Once this is merged into production we will be able to deprecate this repo https://github.com/bgd-labs/aave-governance-ui-helpers and package https://www.npmjs.com/package/@bgd-labs/aave-governance-ui-helpers)
Updated IPFS version (now in IPFS version, there is no payloads explorer screen, all things related to creating a proposal (create screen, create overview screen removed from IPFS version), IPFS version now goes to the app directory, and not separately to pages. The IPFS version is separated from the server version using the next config, namely the extension of the page file. (https://github.com/bgd-labs/aave-governance-v3-interface/blob/feat/update/next.config.js , https://nextjs.org/docs/pages/api-reference/config/next-config-js/pageExtensions )
Completely reworked the logic of the payload explorer screens. There is no store at all, data is received from the server directly and data polling is performed using SWR on the client. Integrated parallel and intercepting routes https://nextjs.org/docs/app/building-your-application/routing/parallel-routes, https://nextjs.org/docs/app/building-your-application/routing/intercepting-routes for payload modal.
Removed
Bignumber.js
.Integrated
@bgd-labs/rpc-env
.Transactions have been slightly reworked, but data updates after transaction still works with RPC for more comfortable UX.
Partially updated and optimized client components.
Added documentation for developers.
Closes #97 Closes #4
Page Speed Analysis
Old Server Version: https://vote.onaave.com/
New Server Version: https://aave-governance-v3-interface-git-feat-update-bgd-labs.vercel.app/
New IPFS Version: https://bafybeidx7h322t2mn3j7xthciumhredtrvrbgd522r7tt3vjmhbefye4ke.ipfs.dweb.link/
Summary of Page Speed Analysis
The new server version (https://aave-governance-v3-interface-git-feat-update-bgd-labs.vercel.app/) shows significant improvements in page speed compared to the old server version (https://vote.onaave.com/). The new server version has a higher score for both mobile and desktop devices, with a faster page load time and faster first contentful paint and first interactive times.
The new IPFS version (https://bafybeidx7h322t2mn3j7xthciumhredtrvrbgd522r7tt3vjmhbefye4ke.ipfs.dweb.link/) has a slower page load time and lower scores compared to the new server version, but still shows some improvements compared to the old server version.