You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The most prominent one is the over-constraining of argument types. Some very specific constraints are needed for the update rules, but in other places the constraints need not be as strict as they are now;
There are also still some Dicts that should be NamedTuples;
We could make more efficient use of Julia's type inference system to get rid of the matches functions that are used for update rule-matching.
Macros, e.g. @symmetrical can be improved for clarity
The text was updated successfully, but these errors were encountered:
This blogpost from Lyndon White mentions several antipatterns for Julia code: https://white.ucc.asn.au/2020/04/19/Julia-Antipatterns.html (thanks @bauglir for pointing this out). Some of the antipatterns mentioned here are also present in the FL code.
The most prominent one is the over-constraining of argument types. Some very specific constraints are needed for the update rules, but in other places the constraints need not be as strict as they are now;
There are also still some
Dicts
that should beNamedTuples
;We could make more efficient use of Julia's type inference system to get rid of the
matches
functions that are used for update rule-matching.Macros, e.g.
@symmetrical
can be improved for clarityThe text was updated successfully, but these errors were encountered: