Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove antipatterns #82

Open
ThijsvdLaar opened this issue Apr 20, 2020 · 1 comment
Open

Remove antipatterns #82

ThijsvdLaar opened this issue Apr 20, 2020 · 1 comment
Assignees
Labels

Comments

@ThijsvdLaar
Copy link
Collaborator

ThijsvdLaar commented Apr 20, 2020

This blogpost from Lyndon White mentions several antipatterns for Julia code: https://white.ucc.asn.au/2020/04/19/Julia-Antipatterns.html (thanks @bauglir for pointing this out). Some of the antipatterns mentioned here are also present in the FL code.

  1. The most prominent one is the over-constraining of argument types. Some very specific constraints are needed for the update rules, but in other places the constraints need not be as strict as they are now;

  2. There are also still some Dicts that should be NamedTuples;

  3. We could make more efficient use of Julia's type inference system to get rid of the matches functions that are used for update rule-matching.

  4. Macros, e.g. @symmetrical can be improved for clarity

@ThijsvdLaar
Copy link
Collaborator Author

Dmitri will propose an improvement to 4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants