Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document difference between EDF and EDF+ #3

Open
robertoostenveld opened this issue Jul 12, 2018 · 2 comments
Open

document difference between EDF and EDF+ #3

robertoostenveld opened this issue Jul 12, 2018 · 2 comments

Comments

@robertoostenveld
Copy link
Collaborator

annotation channel, anything else?

@sappelhoff
Copy link
Member

sappelhoff commented Jul 17, 2018

Related:

  • Is this reader also for EDF+?
  • Is EDF+ supported by BEP_006, or are we really just supporting EDF? EDF+ is definitely supported

This also relates to @chrisfilo 's recent remark:

There was previously some talk to do rudimentary validation of EDF headers in the validator (for example using https://github.com/Pixpipe/edfdecoder) - where does this stand?

... because the referenced edfdecoder works only for EDF, and not EDF+

@palday
Copy link
Collaborator

palday commented Jul 17, 2018

At the moment, I think it's just EDF. I might be willing to consider adding EDF+/GDF/BDF support in the distant future, but I'm not even sure if it makes sense to have it all in the same package or whether there should be a constellation of packages (possibly with a convenience package that imports and wraps them all, a bit like tidyverse in the R world).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants