-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup the install script #341
base: master
Are you sure you want to change the base?
Conversation
bbb-install.sh
Outdated
@@ -111,6 +111,9 @@ main() { | |||
LETS_ENCRYPT_OPTIONS="--webroot --non-interactive" | |||
SOURCES_FETCHED=false | |||
|
|||
# If grep'ing for a key in "apt-key list" is dangerous, should we find a better way to do it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As apt-key is deprecated one should move to managing keys e.g. in /etc/apt/trusted.gpg.d/
entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XSpielinbox is right. Since this is supposed to be a simple cleanup PR, I dropped the key management stuff completely. I'll put something better in a separate PR.
be a better way to decide if we want to stop it
instead of grep'ing for the package name in "dpkg -l" A problem with the grep'ing approach was that if a package was purged, it will still appear on "dpkg -l" and seem like it was installed.
… and bbb-install-2.6.sh
to find a better way of doing this
Four commits - I don't think anything in here should be very controversial, so I packed them all together into one PR.