Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested Data Model Additions / Questions #147

Open
showerst opened this issue Mar 29, 2022 · 1 comment
Open

Suggested Data Model Additions / Questions #147

showerst opened this issue Mar 29, 2022 · 1 comment

Comments

@showerst
Copy link

I have a few suggestions on the data model --

Looking at the Asset model:

  1. Are meeting_date and meeting_time supposed to be local, or always UTC? In either case I think adding an optional meeting_tz field would be helpful, otherwise sorting across multiple jurisdictions becomes impossible. FWIW in openstates we landed on enforcing scraped dates to UTC, and including a timezone. This is also helpful in places like Kentucky with multiple timezones.
  2. Adding an optional field for Opencividata division ID would allow this output to be mixed with other projects more easily.

If you're interested in either of these, I'd be willing to drop a PR. I can also potentially contribute some mappings of ocd-ids and timezones, since I know that the biggest hurdle there is mapping all that data.

@zstumgoren
Copy link
Member

Hey @showerst Sure, those are both great ideas. Would you mind adding those as optional kwargs? Just want to make sure we have some flexibility going forward, especially with regard to the OCD IDs for bodies that aren't currently reflected in the standard. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants