Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes part of #682 #684

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Conversation

shamikbose
Copy link
Contributor

@shamikbose shamikbose commented Jun 5, 2022

medical_data updated to bigbio_pairs schema
Passes all tests

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script biodatasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Updated to `bigbio_pairs` schema
Passes all tests
@mariosaenger mariosaenger self-assigned this Oct 23, 2024
@mariosaenger mariosaenger requested a review from phlobo October 24, 2024 15:12
@mariosaenger
Copy link
Collaborator

@phlobo Please have a look at this dataset. I refactored the implementation to the new HF-hub-based style. I'm not completely happy with the modeling - essentially it's aspect-based text classification rather than text similarity. However, the former isn't properly supported by any of the BigBio schemes.

Copy link
Collaborator

@phlobo phlobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would pick a different task, but apart from that, the PR looks good!

bigbio/hub/hub_repos/samd/README.md Outdated Show resolved Hide resolved
bigbio/hub/hub_repos/samd/README.md Outdated Show resolved Hide resolved
bigbio/hub/hub_repos/samd/samd.py Outdated Show resolved Hide resolved
bigbio/hub/hub_repos/samd/samd.py Outdated Show resolved Hide resolved
phlobo
phlobo previously approved these changes Oct 26, 2024
@phlobo phlobo merged commit 7373ea6 into bigscience-workshop:main Oct 26, 2024
@phlobo
Copy link
Collaborator

phlobo commented Oct 26, 2024

@mariosaenger I realized the old version of the dataset is already on the hub: https://huggingface.co/datasets/bigbio/medical_data
should we delete that one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants