Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set code conventions #43

Closed
jaketae opened this issue Aug 10, 2021 · 3 comments
Closed

Set code conventions #43

jaketae opened this issue Aug 10, 2021 · 3 comments
Assignees

Comments

@jaketae
Copy link
Member

jaketae commented Aug 10, 2021

As the repository gets larger, we will eventually need to decide on a code convention. Though preferences may vary, it's probably safe to stick to the setup in transformers, which is black + isort.

We could create a simplified Makefile and do something like

.PHONY: style

style:
	black .
	isort . --profile=black .

Alternatively, create a .pre-commit-config.yaml.

repos:
  - repo: https://github.com/psf/black
    rev: 21.7b0
    hooks:
      - id: black
  - repo: https://github.com/pycqa/isort
    rev: 5.9.3
    hooks:
      - id: isort
        args: ["--profile", "black"]
@jaketae
Copy link
Member Author

jaketae commented Aug 12, 2021

@wilsonyhlee @tttyuntian Do you have any suggestions or preferred way of doing this?

@tianjianjiang
Copy link
Contributor

@jaketae
Copy link
Member Author

jaketae commented Aug 18, 2021

Closed via #56

@jaketae jaketae closed this as completed Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants