From 0621c0e936eefcfb48ce626fec3d65bdbeb8fead Mon Sep 17 00:00:00 2001
From: anouk <anouk.liberge@u-bordeaux.fr>
Date: Mon, 30 Dec 2024 17:55:22 +0100
Subject: [PATCH] Remove unnecessary route redirect

---
 .../views/volumes/videos/index/meta.blade.php | 90 +++++++++----------
 .../Views/Videos/VideoControllerTest.php      |  6 --
 2 files changed, 44 insertions(+), 52 deletions(-)

diff --git a/resources/views/volumes/videos/index/meta.blade.php b/resources/views/volumes/videos/index/meta.blade.php
index ef3df0a19..9363f91a8 100644
--- a/resources/views/volumes/videos/index/meta.blade.php
+++ b/resources/views/volumes/videos/index/meta.blade.php
@@ -1,51 +1,49 @@
-<div class="panel panel-default">
+<div class="panel panel-default table-responsive">
     <div class="panel-heading">
         <h3 class="panel-title">Video information</h3>
     </div>
-    <div class="panel-body table-responsive">
-        <table class="table">
-            @if ($video->width && $video->height)
-                <tr>
-                    <th>Dimensions</th>
-                    <td>{{ $video->width }} &times; {{ $video->height }} px </td>
-                </tr>
-            @endif
-            @if ($video->size)
-                <tr>
-                    <th>Size</th>
-                    <td>{{ round($video->size / 1E+6, 2) }} MBytes </td>
-                </tr>
-            @endif
-            @if ($video->mimetype)
-                <tr>
-                    <th>MIME</th>
-                    <td><code>{{ $video->mimetype }}</code></td>
-                </tr>
-            @endif
-            @if ($video->taken_at)
-                <tr>
-                    <th>Created</th>
-                    @if (is_array($video->taken_at))
-                        @foreach ($video->taken_at as $value)
-                            <td>{{ $value }}</td>
-                        @endforeach
-                    @else
-                        <td>{{ $video->taken_at }}</td>
-                    @endif
-                </tr>
-            @endif
-            @foreach ($metadata as $key => $field)
-                <tr>
-                    <th>{{ $metadataMap[$key] }}</th>
-                    @if (is_array($field))
-                        @foreach ($field as $value)
-                            <td>{{ $value }}</td>
-                        @endforeach
-                    @else
+    <table class="table">
+        @if ($video->width && $video->height)
+            <tr>
+                <th>Dimensions</th>
+                <td>{{ $video->width }} &times; {{ $video->height }} px </td>
+            </tr>
+        @endif
+        @if ($video->size)
+            <tr>
+                <th>Size</th>
+                <td>{{ round($video->size / 1E+6, 2) }} MBytes </td>
+            </tr>
+        @endif
+        @if ($video->mimetype)
+            <tr>
+                <th>MIME</th>
+                <td><code>{{ $video->mimetype }}</code></td>
+            </tr>
+        @endif
+        @if ($video->taken_at)
+            <tr>
+                <th>Created</th>
+                @if (is_array($video->taken_at))
+                    @foreach ($video->taken_at as $value)
                         <td>{{ $value }}</td>
-                    @endif
-                </tr>
-            @endforeach
-        </table>
-    </div>
+                    @endforeach
+                @else
+                    <td>{{ $video->taken_at }}</td>
+                @endif
+            </tr>
+        @endif
+        @foreach ($metadata as $key => $field)
+            <tr>
+                <th>{{ $metadataMap[$key] }}</th>
+                @if (is_array($field))
+                    @foreach ($field as $value)
+                        <td>{{ $value }}</td>
+                    @endforeach
+                @else
+                    <td>{{ $value }}</td>
+                @endif
+            </tr>
+        @endforeach
+    </table>
 </div>
diff --git a/tests/php/Http/Controllers/Views/Videos/VideoControllerTest.php b/tests/php/Http/Controllers/Views/Videos/VideoControllerTest.php
index 425ed26b6..714675547 100644
--- a/tests/php/Http/Controllers/Views/Videos/VideoControllerTest.php
+++ b/tests/php/Http/Controllers/Views/Videos/VideoControllerTest.php
@@ -20,10 +20,4 @@ public function testShow()
         $this->beGuest();
         $this->get("videos/{$video->id}/annotations")->assertStatus(200);
     }
-
-    public function testShowRedirect()
-    {
-        $this->beUser();
-        $this->get('video-annotate/999')->assertRedirect('/videos/999/annotations');
-    }
 }