-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Edta 2.2.2 - fix path to LTR_FINDER_PARALLEL #52404
Conversation
@BiocondaBot please fetch artifacts |
No artifacts found on the most recent builds. Either the builds failed, the artifacts have been removed due to age, or the recipe was blacklisted/skipped. |
The LTR_retriever 3.0 recipe has the blast - rmblast conflict. Below is a piece of error message from the PR check / Linux Tests:
This is because LTR_retriever 3.0 includes TEsorter in the dependency, which requires |
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
Docker image(s) built:
|
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
Docker image(s) built:
|
This latest artefacts fix the path to LTR_FINDER_parallel |
The latest artifact still solved to use ltr_retriever 2.9.4, but when I pin version for LTR_retriever, it can solve:
It installs well and seems like repeatmasker 4.1.2.p1 can work without rmblast being corrected linked. Maybe try to pin repeatmasker=4.1.2.p1 and see if it can solve? Another idea is to update recipes of tesorter and tir-learner to replace blast with rmblast, so that all EDTA dependencies are blast-free. |
@oushujun ClobberWarning are not necessarily problematic/fatal. I'm more skeptical by this message error:
|
Perviously it won’t solve correctly without pinning. This happened when
adding TEsorter that has blast in it. I feel like this conflict is the root
cause
…On Fri, Dec 6, 2024 at 7:28 AM Jacques Dainat ***@***.***> wrote:
@oushujun <https://github.com/oushujun> ClobberWarning are not
necessarily problematic/fatal.
Is there any reason why ltr_retriever recipe has repeatmasker pinned to
<4.1.5? Maybe relaxing here may help.
—
Reply to this email directly, view it on GitHub
<#52404 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNX4NGRZSB3JO4FKSMHPDL2EGJ6NAVCNFSM6AAAAABSSXEQMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRTGEYTENJVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I remotely remember the later version of repeatmasker (>4.1.5) needs to download repbase or dfam for classification that made it too big to pass the automatic test. |
I have updated lt_retriever and tesorter. |
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
Docker image(s) built:
|
I tested the new LTR_retriever and TEsorter recipes, they both worked as original, so great!
I encountered the same old ClobberError due to installation of both blast and rmblast:
Installation finished and the test run was OK. Finally! I am not sure if the released recipe will also work the same, but I would love to resolve ClobberError by replacing blast with rmblast in the annosine2 recipe. I think that's the last dependency that uses blast. Shujun |
I do not see blast in the annosine2 recipe... |
You are right, sorry, it's tir-learner. |
@mencian yeah I noticed that. Generally speaking, EDTA does not need the functional addition to RepeatModeler2, which is the structural search using LTR_retriever. EDTA is already doing this internally. I am trying to pin it to >2 and also evaluating the old version's performance. |
I've rebuilt |
@Juke34 I tested the v1 RepeatModeler, it did not work correctly. Please help to pin it to >=2.0. Thanks! |
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
Docker image(s) built:
|
@oushujun |
Nothing related to EDTA but to be "clean" this is the RMBlast recipe that has to be modified to be installed using a dedicated directory and linking the exec with a different name (e.g. adding prefix rm_) than those from blast. Then all tools using rmblast should specifically called rm_ |
@Juke34 That's a great point! I am unsure if it's as easy as modifying the conda recipe, but seems like the conflict has been one of the main causes of our troubles. Can we modify it or it has to come from NCBI? |
@oushujun this is feasible, we just have to modify the RMblast recipe, but we have to keep track and deal with all tools using rmblast in their recipe, because their code have to be updated to call the new exec names.
We should notify the dev of these softwares to see if it would be an issue to change the executable name to call in their software. |
@Juke34 I only have control over ltr_retriever, not the remaining tools on the list. That's the part that I think will be difficult. Recipe updates can be done by us, but code updates probably involve the respective developer(s). |
I tested the latest artifact, and the blast/rmblast conflict went away! |
I'll merge this for now; improving the |
and fix version of ltr_retriever (>=3.0.0)
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.