Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More gracefully deal with not-perfectly-integer inputs #938

Merged
merged 3 commits into from
Nov 9, 2023
Merged

More gracefully deal with not-perfectly-integer inputs #938

merged 3 commits into from
Nov 9, 2023

Commits on Nov 8, 2023

  1. Avoid mixing fp32 and int64 sums, as they are not guaranteed to be id… 

    …entical for large counts. Plus other minor optimizations and comments
    @sfiligoi
    sfiligoi committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9df9cc8 View commit details
    Browse the repository at this point in the history

  2. Reuse the astype(np.int64) array, instead of throwing it away

    @sfiligoi
    sfiligoi committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    2fd4948 View commit details
    Browse the repository at this point in the history

  3. Update Changelog

    @sfiligoi
    sfiligoi committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4724fe2 View commit details
    Browse the repository at this point in the history