-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for tvOS platform? #60
Comments
Hey @Duell10111 , I have not thought about it, and I don't have a beforehand experience with tvOS, thus don't know for sure how much efforts it would take to support it. I guess, in the next round of updates in this library, I'll try to build it for tvOS, to at least get a taste of what it takes. |
Hey @birdofpreyru, thanks that would be awesome. |
I tried to add tvOS support by adding the platform to the podspecs. Currently the cmake process seems to not work, with the current setup. The code can be seen here: Logs from the build:
|
@Duell10111 I guess, it needs some correction around here: react-native-static-server/CMakeLists.txt Lines 41 to 59 in 7a58473
If I remember it correctly, when implementing macOS Catalyst support I had a similar problem, and thus there is that if condition, which adds into |
Don't know if it helps: https://rust-lang.github.io/rustup-components-history/x86_64-apple-ios.html aarch64-apple-tvos / x86_64-apple-tvos |
Thank you very much I changed the target x86_64-apple-ios-macabi to x86_64-apple-tvos for testing and now I get a different error. 😅
Sorry if I do not see the error on first place as I am kind of CMake newbie. 😁 |
Clean & re-build. |
Hmm I quite unsure how to clean the CMake cache, clearing the XCode Build Cache did not work unfortunately. |
Removing everything from |
Thanks that worked. EDIT: I got the error solved by adding a tvOS section in the podsec script using the TVOS_DEPLOYMENT_TARGET, instead of Phone target. Now the build seems to work, but the script still fails, but I do not see the next relevant error. Logs:
|
Maybe the error is the line: |
Yeah, it reads like the linker really misses this flag / environmental variable / whatever it is. Can’t help just looking at logs. Though, it got past the pcre2 build - already good :) |
@birdofpreyru you may want to look into running the |
Hmm okay, I pushed my library version I used into a feature branch in my fork, if you want to reproduce it sometime. 😅 |
Could the error be related to the error message:
|
Probably... here it also complains that some variable is missing in the environment... as I said, that's rapidly went into a zone where I can't help just looking at the logs, and right now I don't have time to try troubleshoot it myself — I'm busy with another project. As I said, I'll have a look at building for tvOS when I do the next round of updates for this library, maybe in a week or few; if you don't figure it out yourself by then. |
Yeah no problem, I only try to understand it myself, as I am not using cmake etc. regulary. 😄 |
Ok, I had a brief look at how to build RN apps for tvOS. If I just enable tvOS in Example app project, and try to build it, the build fails right away. Then from documentation I figured out I probably should use this: https://github.com/react-native-tvos/react-native-tvos to setup a separate Example app for tvOS... at this point it already seems as too much hustle for me to take on for free (at least at the current moment), and without a need for any projects I personally have in sight. So, I'll put it on hold, until you, and/or somebody else comes up with funds to sponsor the effort of supporting tvOS; or I'll get some tvOS project myself and need it (does not feel likely in the foreseen future); or I have nothing else to do (very highly unlikely). |
Okay, sad to hear that 🥲, I added a tvOS example app in my fork (https://github.com/Duell10111/react-native-static-server/tree/tvos/exampletvOS) (tvOS runnable with yarn iosTV). |
The pod currently seem to only support iOS, is tvOS support planned?
The text was updated successfully, but these errors were encountered: