Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issues with Dark Theme not fixed in v1.1.6 #3185

Closed
wiz opened this issue Sep 2, 2019 · 8 comments
Closed

UI issues with Dark Theme not fixed in v1.1.6 #3185

wiz opened this issue Sep 2, 2019 · 8 comments
Labels

Comments

@wiz
Copy link
Contributor

wiz commented Sep 2, 2019

These known UI issues were not fixed in time for v1.1.6 merge cutoff and will be tracked in this new issue instead:

  1. Graph icons are black font color

Screen Shot 2019-09-02 at 23 00 01

  1. Progress bar track remains visible after syncing is completed

Screen Shot 2019-09-02 at 22 59 06

  1. Certain DAO icons need re-styling for grey theme

Screen Shot 2019-09-02 at 5 16 08

  1. Trade chat bubbles background color and font color need improvement
    trade-chat
@freimair freimair added the in:gui label Sep 6, 2019
@ghubstan
Copy link
Contributor

ghubstan commented Sep 6, 2019

  1. Text bubble activated by hovering over chart icon in Buy & See BTC windows are not readable, nor styled for dark theme.

unreadable-tooltip-text-2019-09-06

The chart icon itself is also hard to see.

@wiz
Copy link
Contributor Author

wiz commented Sep 7, 2019

Thanks for reporting, that one is definitely an issue with the Dark Mode, but so far haven't figured out how to style that popup bubble. Maybe @ripcurlx has some advice for me how to fix that one?

@ghubstan
Copy link
Contributor

ghubstan commented Sep 9, 2019

  1. Switching back to light mode after restart does not work on 1st attempt (Linux Ubuntu 18)

[How to Reproduce]

  • Start Arbitrator, Alice or Bob desktop
  • Enable dark mode
  • Shut down Arbitrator, Alice or Bob desktop while in dark mode
  • Start Arbitrator, Alice or Bob desktop
  • Disable dark mode (no effect)
  • Enable dark mode
  • Disable dark mode (now it works)

[Expected Results]
Dark mode should be disabled when setting is manually disabled the first time.

[Actual Results]
Dark mode is not disabled when setting is manually disabled the first time.
Dark mode is disabled after manually enabling dark mode, and switching back to light mode a second time.

Bob-LightMode
Arb-LightMode

@wiz
Copy link
Contributor Author

wiz commented Sep 17, 2019

The "remove" button text color is hard to read
Screen Shot 2019-09-17 at 22 23 46

@stale
Copy link

stale bot commented Dec 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Dec 16, 2019
@ghubstan
Copy link
Contributor

Will leaving a comment keep this issue alive?

@stale stale bot removed the was:dropped label Dec 16, 2019
@wiz
Copy link
Contributor Author

wiz commented Dec 17, 2019

@ghubstan I didn't forget about this. I actually looked into the bubbles background color and tried a few fixes, but they still refused to take any coloring from me. It's either a weird quirk of openjfx GUI element styling, or something unusual in the Bisq code

ripcurlx added a commit to ripcurlx/bisq-desktop that referenced this issue Dec 19, 2019
After some testing on Regtest it seems that this workaround is no longer needed.
This fixes the issue for the remove button mentioned in bisq-network#3185.
@ripcurlx
Copy link
Contributor

I think everything except the chat bubbles has been fixed already.

@wiz wiz closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants