Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 53 #1423

Closed
axpoems opened this issue Nov 21, 2023 · 13 comments
Closed

For Cycle 53 #1423

axpoems opened this issue Nov 21, 2023 · 13 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@axpoems
Copy link

axpoems commented Nov 21, 2023

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 9186.05
  • USD requested: 7900
  • BSQ rate: 0.86 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 52 #1401

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Implement waiting animation to new design dev 1200 bisq-network/bisq2#1235
• Apply new design Reference for this design: #1209
• Design new icons for all the waiting states in Bisq Easy
• Introduce the different icons into each buyer/seller states
Improve experience of notification panel and tab view dev 2500 bisq-network/bisq2#1258
• Exploration and definition of a better UI/UX for the notification panel A few mock-up proposals were made and discussed in Matrix.
• Implement new UI tab view (necessary for the new notification panel) A UI re-design is introduced which includes sticky tabviews and scrollable content.
• Update the current notification panel according to the new specs
Fix encoding issues for Windows environments in UnorderedList component dev 100 bisq-network/bisq2#1237 Towards ongoing issue to fine-tune css/styles/etc: #1211
Improve notification handling in desktop app dev 1050 bisq-network/bisq2#1264
Fix reference to unexisting image path dev 200 bisq-network/bisq2#1292
Update app window icons dev 250 bisq-network/bisq2#1296 Towards ongoing issue to fine-tune css/styles/etc: #1211
Clean up and update the Bisq2 grey palette dev 900 bisq-network/bisq2#1302 Towards ongoing issue to fine-tune css/styles/etc: #1211
• Analyse the distribution of greys in the black-white spectrum
• Development of the bisq grey palette based on the usage and grouping
• Introduced the mapping from the previous grey usages to the its new correspondence
Introduce Bisq 2 green palette dev 900 bisq-network/bisq2#1324 Discussion: #1255
• Few proposals were made on Matrix with new green tones
• From the decided green, introduce the Bisq 2 green palette
Unify tab transitions with the other transitions dev 250 bisq-network/bisq2#1332 Resolves issue: #1328
Update the waiting state icons dev 250 bisq-network/bisq2#1333 Towards ongoing issue to fine-tune css/styles/etc: #1211
Change quote message background colour to differentiate from list view dev 150 bisq-network/bisq2#1346 Resolves issue: #1326
Add payment confirmation waiting state icon for BisqEasy dev 150 bisq-network/bisq2#1348

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@ghost ghost added the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Nov 21, 2023
@ghost
Copy link

ghost commented Nov 21, 2023

Info

Read BSQ amount from summary: 9897.22
Read USD amount from summary: 8516.22
Read BSQ rate from summary: 0.86
Parsed lineitem: {"team":"dev","amount":1.39459}
Parsed lineitem: {"team":"dev","amount":2.90541}
Parsed lineitem: {"team":"dev","amount":11622}
Parsed lineitem: {"team":"dev","amount":1050}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":900}
Parsed lineitem: {"team":"dev","amount":900}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":150}
Parsed lineitem: {"team":"dev","amount":150}

Errors

ERROR: Total USD does not match the sum of line items:

  • Summary total: 8516.22 USD
  • Calculated total: 15726.30 USD

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 9897.22 BSQ
  • Calculated total: 9902.58 BSQ

@ghost ghost added the team:dev https://bisq.wiki/Dev_Team label Nov 21, 2023
@ghost
Copy link

ghost commented Nov 21, 2023

Info

Read BSQ amount from summary: 990258
Read USD amount from summary: 8516.22
Read BSQ rate from summary: 0.86
Parsed lineitem: {"team":"dev","amount":1.39459}
Parsed lineitem: {"team":"dev","amount":2.90541}
Parsed lineitem: {"team":"dev","amount":11622}
Parsed lineitem: {"team":"dev","amount":1050}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":900}
Parsed lineitem: {"team":"dev","amount":900}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":150}
Parsed lineitem: {"team":"dev","amount":150}

Errors

ERROR: Total USD does not match the sum of line items:

  • Summary total: 8516.22 USD
  • Calculated total: 15726.30 USD

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 990258.00 BSQ
  • Calculated total: 9902.58 BSQ

@ghost
Copy link

ghost commented Nov 21, 2023

Info

Read BSQ amount from summary: 9902.58
Read USD amount from summary: 8516.22
Read BSQ rate from summary: 0.86
Parsed lineitem: {"team":"dev","amount":1.39459}
Parsed lineitem: {"team":"dev","amount":2.90541}
Parsed lineitem: {"team":"dev","amount":11622}
Parsed lineitem: {"team":"dev","amount":1050}
Parsed lineitem: {"team":"dev","amount":200}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":900}
Parsed lineitem: {"team":"dev","amount":900}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":250}
Parsed lineitem: {"team":"dev","amount":150}
Parsed lineitem: {"team":"dev","amount":150}

Errors

ERROR: Total USD does not match the sum of line items:

  • Summary total: 8516.22 USD
  • Calculated total: 15726.30 USD

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Nov 21, 2023
@MwithM MwithM added this to the For Cycle 53 milestone Nov 22, 2023
@pazza83
Copy link

pazza83 commented Nov 22, 2023

Hi @axpoems

Your previous compensation request for cycle 52 for the following work delivered was:

  • $1200 - Implement waiting animation to new design
  • $2500 - Improve experience of notification panel and tab view
  • $100 - Fix encoding issues for Windows environments in UnorderedList component

If you miss the compensation request deadline and need to request in a subsequent cycle then the USD amount should stay the same for the work completed.

I would recommend putting the USD amounts back to how they were previously or explain why the compensation requested has increased by over 16% in USD terms.

@HenrikJannsen
Copy link

ACK

@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request based on #1423 (comment). Please submit your CR to DAO for voting and post the tx id here afterwards. Thanks!

@axpoems
Copy link
Author

axpoems commented Nov 23, 2023

Cycle 52 BSQ Cycle 52 USD Cycle 53 BSQ Cycle 53 USD Work Title
1621,62 1200 1621,62 1394,59 Implement waiting animation to new design
3378,38 2500 3378,38 2905,41 Improve experience of notification panel and tab view
135,14 100 135,14 116,22 Fix encoding issues for Windows environments in UnorderedList component

The requested BSQ amount for the items mentioned, as shown in the table above, remains consistent in both cycles. The difference in USD arises from applying the ratio between the cycle rates 0.86 / 0.74 = 1.(1621) to maintain BSQ constant. It's important to note that this is not a result of a missed compensation request deadline on my part. Therefore, requesting the same BSQ amount seemed to be the appropriate way to do it.
@pazza83 - If you think this is still a problem then let me know.

@MwithM
Copy link
Contributor

MwithM commented Nov 24, 2023

You should leave the same amount in USD and and update the rate (0.86USD/BSQ). This rule is used whether the rate goes up or down, so sometimes it favors the contributor and sometimes the DAO.

For consistency with past and current contributions, I prefer that you change the USD values of these items to the original ones and reduce the total BSQ amount for compensation.

@pazza83
Copy link

pazza83 commented Nov 24, 2023

@pazza83 - If you think this is still a problem then let me know.

Thanks for the reply.

Historically when contributors miss cycles the next cycle rates apply. The USD requested should remain constant regardless of if BSQ has gone up or down.

IMHO this is the precedent that has been set and I think it is important to maintain it so it is fair for all contributors.

I would recommend putting the same USD amount as the previous cycle for the three previously completed items and altering the BSQ amount request accordingly.

$1200 - Implement waiting animation to new design
$2500 - Improve experience of notification panel and tab view
$100 - Fix encoding issues for Windows environments in UnorderedList component

@axpoems
Copy link
Author

axpoems commented Nov 24, 2023

Thank you for your explanations. From the system's perspective, I understand and agree with all the reasons you've provided. However, in this specific instance, and for me , the procedure feels unjust. That being said, and with no intention to prolong the discussion, I've reverted the values of those three items to their previous state and adjusted the BSQ value accordingly, as you mentioned.

@axpoems
Copy link
Author

axpoems commented Nov 24, 2023

87a9800387f99ecd45e4b630cf3df93c4faec1bab0f1a3e0fbe8aa64e089119b

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Dec 5, 2023
@ghost
Copy link

ghost commented Dec 5, 2023

Issuance by Team:

team amount BSQ amount USD
dev 9186.05 7900.00

Total Issuance: 9186.05 BSQ (equivalent to: 7900.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Dec 5, 2023

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

5 participants