You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.
Title
Team
USD
Link
Notes
PR Review (for v1.9.19): Optimise/simplify some stream filtering for the REST API
NACK - This PR adds the changes to the wrong place. This mistake wasn't caught in PR 7014. The Preferences class already has a clearRetiredNodes method that handles this use-case. I created follow-up PRs to resolve this issue.
utACK - The regex matches ASCII characters according to the Windows-1252 (CP-1252) spec which is a superset of ISO 8859-1 (ISO-Latin-1) but that is fine in our case.
PR Review (for v1.9.19): Improve exception msg and handling when 'Same Bank' BIC/SWIFT blank
SbpForm has a redundant BankNameField variable declaration.
SbpForm defines holder name getters and setters that are identical to superclass.
It's hard for the seller to read the buyer's account details because the string is long, e.g, "Account owner name (first, middle, and initial of last name): Alice A., Mobile no. +71234567890, Bank name SBP Bank". I shortened "Account owner name (first, middle, and initial of last
name)" to "Account owner name". I created follow-up PRs that resolve these issues.
PR Review (for v1.9.19): Fix randomly blank currency box upon opening the Offer screen
utACK - I used a translator to verify the Persian, Chinese Simplified, and Chinese Traditional translations. It would be good for native speakers to verify the translations.
PR Review (for v1.9.19): Added 500+ string translations to Russian language file
It's hard for the seller to read the buyer's account details because the string is long, e.g, "Account owner name (first, middle, and initial of last name): Alice A., Mobile no. +71234567890, Bank name SBP Bank". I shortened "Account owner name (first, middle, and initial of last name)" to "Account owner name".
Before PR #7123, we showed the XMR subaddress popup whenever the user navigated to the account tab. After PR #7123, we show the XMR subaddress popup if the user has an XMR account. However, it's better show the popup if the user has a non-subaddress XMR account.
Summary
8733.62
Contributions delivered
utACK
utACK
utACK
DAO hashes match with my full nodes.
utACK
utACK
utACK
Add bitcoind, seednode, seednode2, mediator, alice, bob, block, and blocks to .PHONY target.
Alejandro's GPG key expired and he extended the key's expiration date.
The PaymentAccount.getSingleTradeCurrency(...) method can return null
in certain cases.
The text was updated successfully, but these errors were encountered: