Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 67 #1724

Open
alvasw opened this issue Feb 12, 2025 · 1 comment
Open

For Cycle 67 #1724

alvasw opened this issue Feb 12, 2025 · 1 comment
Labels
team:dev https://bisq.wiki/Dev_Team
Milestone

Comments

@alvasw
Copy link

alvasw commented Feb 12, 2025

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 8733.62
  • USD requested: 20000
  • BSQ rate: 2.29 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 66 #1700

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
PR Review (for v1.9.19): Optimise/simplify some stream filtering for the REST API dev bisq-network/bisq#7221 utACK - While reviewing this PR I found and fixed unrelated threading issues.
PR Review (for v1.9.19): Remove emzy bsq explorer dev bisq-network/bisq#7213 NACK - This PR adds the changes to the wrong place. This mistake wasn't caught in PR 7014. The Preferences class already has a clearRetiredNodes method that handles this use-case. I created follow-up PRs to resolve this issue.
PR Review (for v1.9.19): Rename provider repository dev bisq-network/bisq#7214 utACK
PR Review (for v1.9.19): Add bisq.mempool.emzy.de to filter of persisted preferences dev bisq-network/bisq#7222 utACK
PR Review (for v1.9.19): Add 2 new BTC nodes dev bisq-network/bisq#7231 utACK
PR Review (for v1.9.19): Produce exclusively low-R signatures from wallet keys dev bisq-network/bisq#7238 utACK.
PR Review (for v1.9.19): Add missing isBmFullNode parameter dev bisq-network/bisq#7239 utACK
PR Review (for v1.9.19): Fix broken low-R signing with a password encrypted wallet dev bisq-network/bisq#7242 utACK
PR Review (for v1.9.19): URL was broken with the /bisq path and just redirecting to mempool front page dev bisq-network/bisq#7246 ACK
PR Review (for v1.9.19): Add suddenwhipvapor onion xmr explorer dev bisq-network/bisq#7245 utACK
PR Review (for v1.9.19): Update seednode burningman oracle keys dev bisq-network/bisq#7248 utACK
PR Review (for v1.9.19): Sort foreign alphabet payment methods above the untranslated ones. dev bisq-network/bisq#7251 utACK - The regex matches ASCII characters according to the Windows-1252 (CP-1252) spec which is a superset of ISO 8859-1 (ISO-Latin-1) but that is fine in our case.
PR Review (for v1.9.19): Improve exception msg and handling when 'Same Bank' BIC/SWIFT blank dev bisq-network/bisq#7258 utACK
PR Review (for v1.9.19): "Transfer Same Bank" & "Transfer Specific Banks" match case-insentitivity dev bisq-network/bisq#7257 utACK
PR Review (for v1.9.19): Language strings file cleanup; added missing, applied rename dev bisq-network/bisq#7253 utACK
PR Review (for v1.9.19): Create payment method "Faster Payments System (SBP)" for Russian Ruble dev bisq-network/bisq#7255 ACK + Nit -
  • SbpForm has a redundant cast to SbpAccountPayload
  • SbpForm has a redundant BankNameField variable declaration.
  • SbpForm defines holder name getters and setters that are identical to superclass.
  • It's hard for the seller to read the buyer's account details because the string is long, e.g, "Account owner name (first, middle, and initial of last name): Alice A., Mobile no. +71234567890, Bank name SBP Bank". I shortened "Account owner name (first, middle, and initial of last
name)" to "Account owner name". I created follow-up PRs that resolve these issues.
PR Review (for v1.9.19): Fix randomly blank currency box upon opening the Offer screen dev bisq-network/bisq#7259 utACK
PR Review (for v1.9.19): New option in PhoneNumberValidator to enforce exact number of digits dev bisq-network/bisq#7252 Nit - Jamaica (JMM) has two codes. I created a follow-up PR to fix this.
PR Review (for v1.9.19): Create payment method "Faster Payments System (SBP)" for Russian Ruble dev bisq-network/bisq#7265 utACK - I used a translator to verify the Persian, Chinese Simplified, and Chinese Traditional translations. It would be good for native speakers to verify the translations.
PR Review (for v1.9.19): Added 500+ string translations to Russian language file dev bisq-network/bisq#7268 utACK
PR Review (for v1.9.19): Added 500+ string translations to Russian language file dev bisq-network/bisq#7269 utACK
PR Review (for v1.9.19): Add missing swagger doc directory dev bisq-network/bisq#7299 utACK
PR Review (for v1.9.19): Update seednode install script to generate ECDSA key for BM oracle node dev bisq-network/bisq#7325 utACK
PR Review (for v1.9.19): Add instruction to select JDK version at build time dev bisq-network/bisq#7327 utACK
PR Review (for v1.9.19): Fix typo in Argentinian Peso (ARS) message dev bisq-network/bisq#7326 utACK
PR Review (for v1.9.19): fix: remove unnecessary null check, use correct marker class, add mis… dev bisq-network/bisq#7348 utACK
PR Review (for v1.9.19): Add link to trading rules wiki article in Tac Window dev bisq-network/bisq#7349 utACK
PR Review (for v1.9.19): Add suddenwhipvapor mediator instance onion dev bisq-network/bisq#7350 utACK
PR Review (for v1.9.19): fix: Utilities.getShortId and FluentProtocol.preCondition usage dev bisq-network/bisq#7351 utACK
PR Review (for v1.9.19): Prepare activation to reduce min security deposit dev bisq-network/bisq#7357 utACK
PR Review (for v1.9.19): Change MIN_SECURITY_DEPOSIT_CHANGE_ACTIVATION_DATE to 17.2.2025 dev bisq-network/bisq#7364 utACK
PR Review (for v1.9.19): Reduce maximum trade size for unsigned payment accounts dev bisq-network/bisq#7364 utACK - I found some bugs while I was reviewing this PR.
PR Review (for v1.9.19): Ensure AutoConfirmSettings is reset if it contains my retired explorer dev bisq-network/bisq#7364 utACK - I found some bugs while I was reviewing this PR.
Fixed, re-wrote, and tested (on all OSes) Bisq 1 installer verification instructions dev https://bisq.wiki/Downloading_and_installing#Bisq_1:_Obtain_signature_files_for_installer_files
bisq: PR Review bisq-network/bisq#7364 dev bisq-network/bisq#7364

utACK

bisq: PR Review bisq-network/bisq#7365 dev bisq-network/bisq#7365

utACK

bisq: PR Review bisq-network/bisq#7368 dev bisq-network/bisq#7368

utACK

bisq: PR Review bisq-network/bisq#7373 dev bisq-network/bisq#7373

DAO hashes match with my full nodes.

bisq: PR Review bisq-network/bisq#7374 dev bisq-network/bisq#7374

utACK

bisq: PR Review bisq-network/bisq#7375 dev bisq-network/bisq#7375

utACK

bisq: PR Review bisq-network/bisq#7386 dev bisq-network/bisq#7386

utACK

bisq: Makefile: Add exec-commands to .PHONY target dev bisq-network/bisq#7369

Add bitcoind, seednode, seednode2, mediator, alice, bob, block, and blocks to .PHONY target.

bisq: Sbp trade UI fixes dev bisq-network/bisq#7370
bisq: Update Alejandro's public key dev bisq-network/bisq#7371

Alejandro's GPG key expired and he extended the key's expiration date.

bisq: Fix phone number required lengths dev bisq-network/bisq#7372
bisq: XMR: Fix broken subaddress docs link dev bisq-network/bisq#7377
bisq: Improve XMR subaddress popup behaviour dev bisq-network/bisq#7378
bisq: AltCoinAccountsDataModel: Handle XMR detection NullPointerException dev bisq-network/bisq#7379

The PaymentAccount.getSingleTradeCurrency(...) method can return null
in certain cases.

bisq: Implement deflate compressed log zipper dev bisq-network/bisq#7380
bisq: Use deflate compressed log zipper in backup view dev bisq-network/bisq#7381
bisq: BackupView: Show error message if log files zipping fail dev bisq-network/bisq#7382
bisq: FileUtils: Close files after scanning for keywords dev bisq-network/bisq#7384
dev 20000 Total for items above.
@alvasw
Copy link
Author

alvasw commented Feb 12, 2025

009379de18c5b1b354250bee1b929d9ce174daad48787d293c903950968da3fb

@MwithM MwithM added the team:dev https://bisq.wiki/Dev_Team label Feb 13, 2025
@MwithM MwithM moved this to In Review in Compensation Request Board Feb 13, 2025
@MwithM MwithM added this to the Cycle 67 milestone Feb 13, 2025
@MwithM MwithM moved this from In Review to Proposal Submitted in Compensation Request Board Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:dev https://bisq.wiki/Dev_Team
Projects
Status: Proposal Submitted
Development

No branches or pull requests

2 participants