Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong argument name in Electrum and Esplora clients full_scan() methods #576

Open
thunderbiscuit opened this issue Jul 26, 2024 · 0 comments
Open

Wrong argument name in Electrum and Esplora clients full_scan() methods #576

thunderbiscuit opened this issue Jul 26, 2024 · 0 comments
Milestone
1.0.0-beta

Comments

@thunderbiscuit
Copy link
Member

thunderbiscuit commented Jul 26, 2024 •
edited
Loading

In both clients our current function takes a first argument called full_scan_request, when in fact on the Rust side it's simply called request.
@thunderbiscuit thunderbiscuit changed the title Wrong argument name in electrum client's full_scan() method Wrong argument name in Electrum and Esplora's clients full_scan() methods Jul 26, 2024
@thunderbiscuit thunderbiscuit changed the title Wrong argument name in Electrum and Esplora's clients full_scan() methods Wrong argument name in Electrum and Esplora clients full_scan() methods Jul 26, 2024
@thunderbiscuit thunderbiscuit added this to the 1.0 Release milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-beta
Development

No branches or pull requests
1 participant
@thunderbiscuit