Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing multiple swift bindings modulemap collision #621

Open
reez opened this issue Nov 4, 2024 · 2 comments
Open

Importing multiple swift bindings modulemap collision #621

reez opened this issue Nov 4, 2024 · 2 comments
Labels
bug Something isn't working
Milestone
1.0.0-beta

Comments

@reez
Copy link
Collaborator

reez commented Nov 4, 2024

Describe the bug
When Importing two swift frameworks generated via FFI there is a Build error.

Showing Recent Issues
duplicate output file '/include/module.modulemap' on task: ProcessXCFramework /DerivedData/Build/Products/Debug-iphonesimulator/libbdkffi.a ios simulator

Showing Recent Issues
Multiple commands produce '/Build/Products/Debug-iphonesimulator/include/module.modulemap'

Showing Recent Issues
Command: ProcessXCFramework /Build/Products/Debug-iphonesimulator/libportal.a ios simulator

Showing Recent Issues
Command: ProcessXCFramework /Build/Products/Debug-iphonesimulator/libbdkffi.a ios simulator

To Reproduce
Import bdk-swift and some other swift bindings generated the same way

Expected behavior

Build environment

  • BDK tag/commit:
  • OS+version:
  • Rust/Cargo version:
  • Rust/Cargo target:

Additional context
@reez reez added the bug Something isn't working label Nov 4, 2024
@reez reez mentioned this issue Nov 4, 2024
Open
@reez
Copy link
Collaborator Author

reez commented Nov 4, 2024 •
edited
Loading

Fails using bdk-swift:

Succeeds using bdk-swift:

The other swift bindings I was importing was using uniffi = { version = "0.26.1", optional = true }

@reez
Copy link
Collaborator Author

reez commented Nov 5, 2024

The other swift bindings I was importing was using uniffi = { version = "0.26.1", optional = true }

I tested bumping the other swift bindings I was importing from 0.26.1 to 0.28.0, to match bdk-swift beta 2+5, and the results were the same...

Fails using bdk-swift:

Succeeds using bdk-swift:

@thunderbiscuit thunderbiscuit added this to the 1.0 Release milestone Nov 14, 2024
@notmandatory notmandatory moved this to Todo in BDK-Bindings Nov 22, 2024
@notmandatory notmandatory added this to BDK Nov 22, 2024
@notmandatory notmandatory moved this to Todo in BDK Nov 22, 2024
@notmandatory notmandatory removed this from BDK Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-beta
Development

No branches or pull requests
2 participants
@reez @thunderbiscuit