Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdk_esplora: handle empty /blocks response #1696

Open
notmandatory opened this issue Nov 14, 2024 · 0 comments · May be fixed by #1725
Open

bdk_esplora: handle empty /blocks response #1696

notmandatory opened this issue Nov 14, 2024 · 0 comments · May be fixed by #1725
Labels
audit Suggested as result of external code audit module-blockchain
Milestone
1.0.0-beta

Comments

@notmandatory
Copy link
Member

notmandatory commented Nov 14, 2024 •
edited
Loading

"a rogue Esplora server can make an application crash by returning an empty list of blocks to a /blocks request, as latest_blocks is assumed to never be empty in fetch_block()"
@notmandatory notmandatory added this to BDK Nov 14, 2024
@notmandatory notmandatory converted this from a draft issue Nov 14, 2024
@notmandatory notmandatory added audit Suggested as result of external code audit module-blockchain labels Nov 14, 2024
@notmandatory notmandatory moved this to Todo in BDK Nov 14, 2024
@notmandatory notmandatory changed the title esplora: handle empty /blocks response bdk_esplora: handle empty /blocks response Nov 14, 2024
@rustaceanrob rustaceanrob linked a pull request Nov 16, 2024 that will close this issue
Open
8 tasks
@notmandatory notmandatory moved this from Todo to Needs Review in BDK Nov 18, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit Suggested as result of external code audit module-blockchain
Projects
BDK
Status: Needs Review
Milestone
1.0.0-beta
Development

Successfully merging a pull request may close this issue.

Check recent blocks are not empty rustaceanrob/bdk
1 participant
@notmandatory