Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error for invalid descriptor types #1701

Open
notmandatory opened this issue Nov 14, 2024 · 0 comments
Open

Return error for invalid descriptor types #1701

notmandatory opened this issue Nov 14, 2024 · 0 comments
Labels
audit Suggested as result of external code audit module-wallet

Comments

@notmandatory
Copy link
Member

notmandatory commented Nov 14, 2024

"The library will crash on descriptors without an address form, as it assumes it can always get it but doesn't check it. For instance importing a raw() descriptor would make BDK crash internally. This can be an issue for a server providing an API to register descriptors and monitor them using BDK."

"The descriptor is not checked in Wallet::create_with_params (it only is in load_with_params), allowing to create a Wallet with an incompatible (multipath, hardened steps, ..) descriptor which would break a number of invariants during usage of the Wallet."

@notmandatory notmandatory added this to BDK Nov 14, 2024
@notmandatory notmandatory converted this from a draft issue Nov 14, 2024
@notmandatory notmandatory moved this to Todo in BDK Nov 14, 2024
@notmandatory notmandatory added module-wallet audit Suggested as result of external code audit labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit Suggested as result of external code audit module-wallet
Projects
Status: Todo
Development

No branches or pull requests

1 participant