Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs for Wallet:create_tx when empty output vector #1717

Open
notmandatory opened this issue Nov 14, 2024 · 0 comments
Open

Fix docs for Wallet:create_tx when empty output vector #1717

notmandatory opened this issue Nov 14, 2024 · 0 comments
Labels
audit Suggested as result of external code audit documentation Improvements or additions to documentation module-wallet

Comments

@notmandatory
Copy link
Member

"In Wallet::create_tx when the outputs vector of the transaction is empty, you have a comment "We have a drain_to address and the utxos we must spend (this happens, for example, when we RBF)" which seems misleading to me. If by "when we RBF" you mean what build_fee_bump does, then it's incorrect as build_fee_bump won't set params.drain_to."
@notmandatory notmandatory added audit Suggested as result of external code audit documentation Improvements or additions to documentation module-wallet labels Nov 14, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 14, 2024
@notmandatory notmandatory added this to BDK Nov 14, 2024
@notmandatory notmandatory moved this to Todo in BDK Nov 14, 2024
@notmandatory notmandatory removed this from the 1.0.0-beta milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit Suggested as result of external code audit documentation Improvements or additions to documentation module-wallet
Projects
BDK
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notmandatory