Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce standardness rules for TxBuilder::add_data #1718

Open
notmandatory opened this issue Nov 14, 2024 · 0 comments · May be fixed by #1726
Open

Enforce standardness rules for TxBuilder::add_data #1718

notmandatory opened this issue Nov 14, 2024 · 0 comments · May be fixed by #1726
Labels
audit Suggested as result of external code audit module-wallet

Comments

@notmandatory
Copy link
Member

"TxBuilder::add_data could enforce common standardness rules (max 80 bytes and at most one such output per transaction). It would also prevent a potential panic to be triggered from within rust-bitcoin (in push_slice_no_opt) if the data is too large, although i don't think it's realistic as a request for creating a 4GiB OP_RETURN would probably fail before then."

@notmandatory notmandatory added audit Suggested as result of external code audit module-wallet labels Nov 14, 2024
@notmandatory notmandatory added this to BDK Nov 14, 2024
@notmandatory notmandatory moved this to Discussion in BDK Nov 14, 2024
@rustaceanrob rustaceanrob linked a pull request Nov 16, 2024 that will close this issue
8 tasks
@notmandatory notmandatory moved this from Discussion to Needs Review in BDK Nov 18, 2024
@notmandatory notmandatory modified the milestone: 1.0.0-beta Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit Suggested as result of external code audit module-wallet
Projects
Status: Needs Review
Development

Successfully merging a pull request may close this issue.

1 participant