Calculate latency, receive uplink RSSI, calculate bandwidth congestion and packet rate #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved latency measurement from the radio driver to a new Latency class for better organization and readability. - Generalized the LinkStatistics class to allow for easy addition of other link statistics in the future.
In a valiant attempt to appease the relentless gods of autopep8 and the all-seeing eyes of CI, I embarked on an epic journey to fix double-quoted strings and reorder imports.
- Modified start() and stop() methods for better thread management. - Implemented thread reinitialization on start after stop.
- Refactor link quality callback to contain signal health obj with additional signal health information - Parse uplink RSSI in ack into signal health obj
Return a dictionary with all updated signal quality statistics in the callback, rather than the entire class.
Renamed SignalHealth class to RadioLinkStatistics to better reflect its responsibility of handling and processing radio-specific metrics.
|
In the last commit, I renamed the I also want to bring up the consideration of feeding data from |
- Move radio link statistics into (universal) link statistics object - Stop updating radio link statistics from callbacks if stop is called on link statistics. User probably will expect this behavior. - Deprecation warning on calling link_quality_updated directly. Proxy call to link_statistics.link_quality_updated until removal.
These generally should be visible and fixed. + fix deprecated setDaemon warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #480 and #477
🚀 Features
Introduces a framework for link statistics, enabling the tracking of various metrics, starting with latency measurement.
Refactors link quality callback to contain signal health obj with additional signal health information:
📝 To-do
The implementation improves the lib's ability to monitor communication quality and lays the groundwork for further enhancements in link statistics.