Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility? #28

Open
sursh opened this issue Oct 14, 2015 · 8 comments
Open

Python 3 compatibility? #28

sursh opened this issue Oct 14, 2015 · 8 comments

Comments

@sursh
Copy link

sursh commented Oct 14, 2015

Hi folks. Planning Python 3 compatibility for this awesome tool? I'm getting SyntaxErrors, looks like from print statements missing parens.

<3

@jehiah
Copy link
Member

jehiah commented Oct 14, 2015

@sursh python3 compatibility would be awesome. Any interest in submitting some pull requests for the incompatibilities you uncovered?

@sursh
Copy link
Author

sursh commented Oct 14, 2015

No, can't help out, my plate is a bit full right now.

On Oct 14, 2015, at 9:40 AM, Jehiah Czebotar [email protected] wrote:

@sursh python3 compatibility would be awesome. Any interest in submitting some pull requests for the incompatibilities you uncovered?


Reply to this email directly or view it on GitHub.

@jehiah
Copy link
Member

jehiah commented Oct 14, 2015

unfortunately i know that state all too well. Thanks for getting this issue started though!

@Shadhopson
Copy link

I think I can take care of that! The plan would be to run python-modernize, which is a program that makes programs compatible for 2.6 - the 3s, and then clear up any additional errors that pop up when I run it in Python 3. I've done that for bar_chart.py, and can push it your way to see if that's what you'd like for the rest of them. Also let me know if you have any bundles of tests that are good to run to more concretely make sure everything is still working properly.

@sursh sursh closed this as completed Jul 15, 2016
@sursh sursh reopened this Jul 15, 2016
@sursh
Copy link
Author

sursh commented Jul 15, 2016

@Shadhopson still up for this?

@sursh
Copy link
Author

sursh commented Jul 15, 2016

oh hey, look at #35. Just needs to be merged in.

@graysky2
Copy link

graysky2 commented May 11, 2019

@jehiah - I realize this is ~3 years old but python3 native would be great if you can spare some time.

I applied #35 and found that it is working as expected with python 3.7.3 (tested data_hacks/histogram.py). Good job @melor !

@harrybiddle
Copy link

Just to give an update in 2020, right now I found two ways to install data_hacks with Python 3 compatibility:

  1. Install @nicholasren's fork: pip install data_hacks3
  2. Install @melor's fork: pip install -e git://github.com/melor/data_hacks.git@py3#egg=data_hacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants