[bitnami/valkey-cluster] the redis_url for redis_exporter should use rediss/redis scheme, not valkeys/valkey. #29589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: a <[email protected]>
|
Thanks for your contribution. Could you please bump the chart version in the Chart.yaml? |
Signed-off-by: a <[email protected]>
|
@carrodher i incremented patch |
Signed-off-by: Bitnami Containers <[email protected]>
javsalgar
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
jotamartos
approved these changes
Sep 26, 2024
mike12806
pushed a commit
to mike12806/charts
that referenced
this pull request
Oct 30, 2024
…rediss/redis scheme, not valkeys/valkey. (bitnami#29589) * change metrics url schema valkeys,valkey -> rediss,redis Signed-off-by: a <[email protected]> * bump version Signed-off-by: a <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: a <[email protected]> Signed-off-by: a <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
change the scheme used to form the metrics target url
Benefits
this makes metrics work, as redis_exporter does not support valkeys/valkey scheme
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.