[bitnami/contour] Unable to create a defaultBackend with a mounted Volume

[GreatSymphonia]

Name and Version

bitnami/contour

What architecture are you using?

None

What steps will reproduce the bug?

When attempting to create a contour ingress with a default backend, I am unable to create one with an extraVolume.

Are you using any custom parameters or values?

  extraVolumes:
    - emptyDir: {}
      name: nginx
  extraVolumeMounts:
    - mountPath: /opt/bitnami/nginx/tmp
      name: nginx

What is the expected behavior?

I expect it to create a defaultBackend container (nginx with a default 404 landing page) with the aforementionned volume

What do you see instead?

shell@shell:~$ helm upgrade --install lan-contour bitnami/contour --namespace lan-contour -f system/Lan_ETS/contour/values.yaml
Error: UPGRADE FAILED: YAML parse error on contour/templates/default-backend/deployment.yaml: error converting YAML to JSON: yaml: line 106: did not find expected '-' indicator

Additional information

No response

[javsalgar]

Hi!

Thank you so much for reporting. I found the issue in default-backend/deployment.yaml.

Instead of:

        {{- if .Values.defaultBackend.extraVolumes }}
        volumes: {{- include "common.tplvalues.render" ( dict "value" .Values.defaultBackend.extraVolumes "context" $ ) | nindent 6 }}
        {{- end }}

It should be

        {{- if .Values.defaultBackend.extraVolumes }}
        volumes: {{- include "common.tplvalues.render" ( dict "value" .Values.defaultBackend.extraVolumes "context" $ ) | nindent 8 }}
        {{- end }}

As you discovered the issue, would you like to submit a PR?

[GreatSymphonia]

Hi, the lines that you are referencing are as follow in the main:

      {{- if .Values.defaultBackend.extraVolumes }}
      volumes: {{- include "common.tplvalues.render" ( dict "value" .Values.defaultBackend.extraVolumes "context" $ ) | nindent 6 }}
      {{- end }}

I suppose they'd need one further level of indentation to match the expected level, so 6 -> 8? Or should it be defenitely 10 as you are stating (It's my first ever contact with editing Helm charts sources in such a way, sorry if my question is dumb)

Can you confirm I correctly understand the issue at point?

[javsalgar]

Hi,

You are right! It was 8, my mistake. I updated the comment before

[github-actions]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[github-actions]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.