Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing available directives in the Redis configuration for RDB in redis chart #31223

Open
AliyevH opened this issue Jan 6, 2025 · 4 comments
Assignees
Labels

Comments

@AliyevH
Copy link

AliyevH commented Jan 6, 2025

Name and Version

bitnami/redis 20.6.1

What is the problem this feature will solve?

Tried to configure RDB feature in helm chart.
Looks like directives are missing to set configuration from values files.

In the Redis cluster chart, these directives exist.

For example: Link

Is there any other way to configure RDB with possible configurations and disable AOF?

What is the feature you are proposing to solve the problem?

Options for RDB:

stop-writes-on-bgsave-error:
rdbcompression: 
rdbchecksum:
dbfilename:
save:
dir:
@github-actions github-actions bot added the triage Triage is needed label Jan 6, 2025
@carrodher
Copy link
Member

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

@carrodher carrodher added the redis label Jan 7, 2025
@AliyevH
Copy link
Author

AliyevH commented Jan 7, 2025

I will be glad to contribute.
I will analyze, add feature and share here steps.

@AliyevH
Copy link
Author

AliyevH commented Jan 7, 2025

@carrodher

I would like to clarify first.

In redis chart
Currently commonConfiguration directive includes only save and appendonly options. Link
And redis.conf only contains these two configurations.

From redis-cluster chart
We can see that redis-default.conf is written from official website.

I would like to apply same logic here also. Write default redis configuration. and overwrite if user is defined custom one.

  1. Remove commonConfiguration
  2. Create default redis.conf from official website.
  3. Add defaultConfigOverride to redis values as in redis-cluster chart.
  4. In configmap.tpl check defaultConfigOverride.

@carrodher
Copy link
Member

Yes, that’s expected since, ultimately, both Helm charts are distinct products. The logic may differ as features are implemented based on user feedback or to address specific use cases. Similarly, we often receive contributions from users that apply changes to a specific Helm chart (e.g., Redis standalone) but are not extended to others (e.g., Redis Cluster).

If you have changes in mind, feel free to submit a PR. The team would be happy to review your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants