Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the token selector #385

Open
giorgionocera opened this issue Jul 13, 2022 · 14 comments
Open

Improve the token selector #385

giorgionocera opened this issue Jul 13, 2022 · 14 comments
Assignees
Labels
bug Something isn't working Urgent Very important task to be solved as soon as possible.

Comments

@giorgionocera
Copy link
Contributor

giorgionocera commented Jul 13, 2022

At the moment, we are using a select (dropdown) to let the user select a token in the swap component. Due to the fact that we have a big number of tokens (which number should increase soon), we should propose a new component for the token selection.

Some suggestions:

  • We can change the dropdown with a dialog
  • We can add a search bar inside the dialog
  • We can add other info for each asset (Available asset, price, etc.)
  • We can sort by available balances

Some references:

  • Uniswap
  • Astroport

We need the design for such a component (also the swap one).
swap-component

@giorgionocera giorgionocera added enhancement New feature or request High Priority After all urgent tasks are closed or stalled. labels Jul 13, 2022
@giannnni
Copy link

giannnni commented Jul 13, 2022

Due to a redesign of the entire Swap Component, I could suggest a better solution that could include some extra help for users like a search field and a small "Recent Swapped Token" carousel.

You could see the new select component just below:
image

You can also see the Swap Component redesigned here:
Schermata 2022-07-13 alle 16 04 51

@giannnni giannnni assigned giorgionocera and unassigned giannnni Jul 13, 2022
@giorgionocera
Copy link
Contributor Author

I think it is a nice solution. Thank you!
Do you have also the mobile and tablet versions?

Anyway, let's see what @angelorc thinks about it.

@giannnni
Copy link

giannnni commented Jul 14, 2022

Yes, you could see here a minimized version for mobile only (opened as a bottom sheet):

· Base version:
image
· Slippage menu open:
image
· Select Token open:
image

@giorgionocera
Copy link
Contributor Author

It is very nice. However I think this blur could be an issue at the moment, but let's wait for feedback from @DavideSegullo.

@DavideSegullo
Copy link
Contributor

@giorgionocera It's better if we doesn't use it if not required

@giorgionocera
Copy link
Contributor Author

@giannnni, can we remove it? Or is it required?

@giannnni
Copy link

Ok, let's move to solid color #311D3E

@giorgionocera giorgionocera removed their assignment Jul 18, 2022
@giorgionocera
Copy link
Contributor Author

Okay, so now let's only wait for feedback from @angelorc 😄

@giorgionocera
Copy link
Contributor Author

giorgionocera commented Jul 20, 2022

As from the meeting with @angelorc, we need:

  • reduce margins in tokens selector;
  • move the FanToken name under the symbol.
    So please @giannnni , let's perform these edits! 💪

@giannnni
Copy link

I fixed the table reducing margins and moving fantoken name under symbol.
Tell me if it's enough or you need less margins (I suggest not).

Here my proposal: image

@giannnni giannnni assigned giorgionocera and unassigned giannnni Jul 22, 2022
@giorgionocera
Copy link
Contributor Author

Yeah, I think it could be nice! Thank you @giannnni !
@DavideSegullo we can move it in development!

@giorgionocera giorgionocera removed their assignment Jul 22, 2022
@giorgionocera giorgionocera added this to the New Version Release milestone Jul 22, 2022
@giorgionocera
Copy link
Contributor Author

This also includes issue #335.

@giorgionocera
Copy link
Contributor Author

Thank you!

@giorgionocera
Copy link
Contributor Author

I think that in the desktop version the information on the amount of token available should be visible at every moment of the swap action. We need to bring it back.

@giorgionocera giorgionocera reopened this Jul 29, 2022
@giorgionocera giorgionocera removed this from the New Version Release milestone Jul 29, 2022
@giorgionocera giorgionocera added bug Something isn't working Urgent Very important task to be solved as soon as possible. and removed Review enhancement New feature or request High Priority After all urgent tasks are closed or stalled. labels Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Urgent Very important task to be solved as soon as possible.
Projects
None yet
Development

No branches or pull requests

4 participants