Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve QR Code Flow #14

Open
DavideSegullo opened this issue Jun 13, 2022 · 6 comments
Open

Improve QR Code Flow #14

DavideSegullo opened this issue Jun 13, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request high priority After all urgent tasks are closed or stalled

Comments

@DavideSegullo
Copy link

We should improve the QR Code scan for wallet connect flow, actual design:
image

The actual implementation have two issues:

  1. Connect Wallet is not required, because if the camera sees a qr code, it scans it automatically.
  2. Actually we have a solid background, but it seems to be bad, because the user can only see a small square of the camera, we can use something like a transparent background, see the screenshot below for some references.

unknown

@DavideSegullo DavideSegullo added enhancement New feature or request high priority After all urgent tasks are closed or stalled design It's a design related issue labels Jun 13, 2022
@gabriele-pala
Copy link

@DavideSegullo
Fixed, is in Cosmonautico 0.6.

@giorgionocera
Copy link

Thank you @gabriele-pala, @zheleznov163 we can move to development! 💪

@giorgionocera giorgionocera removed the design It's a design related issue label Jun 28, 2022
zheleznov163 added a commit that referenced this issue Jul 1, 2022
zheleznov163 added a commit that referenced this issue Jul 5, 2022
@giorgionocera
Copy link

At the moment, the implementation is different from the design. We have squared borders instead of rounded ones.

It is not an urgent fix, but we need to fix it.

Implementation:
telegram-cloud-photo-size-4-5981144274017827282-y

Design:
image

@giorgionocera
Copy link

Moreover, @giulioaiello, we need a text for this screen. We cannot use "[...] when lorem ipsum" 😂

@giulioaiello
Copy link

As i see, it's only necessary to point the camera on the QR, so i suggest:
"frame the QR code with your camera"

@DavideSegullo
Copy link
Author

@zheleznov163 Can we verify the comment from @giorgionocera and can we also the text that @giulioaiello suggested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority After all urgent tasks are closed or stalled
Projects
None yet
Development

No branches or pull requests

5 participants