Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General reconnect failure #148

Open
balena opened this issue Oct 27, 2020 · 0 comments
Open

General reconnect failure #148

balena opened this issue Oct 27, 2020 · 0 comments

Comments

@balena
Copy link
Contributor

balena commented Oct 27, 2020

DNS poll, Kubernetes, Kubernetes DNS, Kubernetes DNS SRV and Rancher strategies all don't reconnect nodes case they disconnect for any reason. They need that the backing service discovery also bounces the list, which doesn't always (never?) happen.

This generated the series of PR's #143, #144, #145, #146 and #147.

The logic can be greatly simplified by passing the whole list of nodes to Cluster.Strategy.connect_nodes/4, as internally it already lists the connected nodes and connect only the "added" ones. Check here: https://github.com/bitwalker/libcluster/blob/master/lib/strategy/strategy.ex#L43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant