From 690f4a0ae98ccb122230b5ff5d6afef0730b3347 Mon Sep 17 00:00:00 2001 From: Cesar Gonzalez Date: Fri, 22 Dec 2023 16:14:02 -0600 Subject: [PATCH] [PM-5134] Make Default Setting for Overlay "On Focus" (#7297) --- apps/browser/src/background/main.background.ts | 1 + apps/browser/src/background/runtime.background.ts | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/apps/browser/src/background/main.background.ts b/apps/browser/src/background/main.background.ts index 19ad2bff9fc..91bc2875dec 100644 --- a/apps/browser/src/background/main.background.ts +++ b/apps/browser/src/background/main.background.ts @@ -687,6 +687,7 @@ export default class MainBackground { this.logService, this.configService, this.fido2Service, + this.settingsService, ); this.nativeMessagingBackground = new NativeMessagingBackground( this.cryptoService, diff --git a/apps/browser/src/background/runtime.background.ts b/apps/browser/src/background/runtime.background.ts index de43e585603..25ada1356be 100644 --- a/apps/browser/src/background/runtime.background.ts +++ b/apps/browser/src/background/runtime.background.ts @@ -1,4 +1,5 @@ import { NotificationsService } from "@bitwarden/common/abstractions/notifications.service"; +import { SettingsService } from "@bitwarden/common/abstractions/settings.service"; import { ConfigServiceAbstraction } from "@bitwarden/common/platform/abstractions/config/config.service.abstraction"; import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service"; import { LogService } from "@bitwarden/common/platform/abstractions/log.service"; @@ -14,6 +15,7 @@ import { } from "../auth/popup/utils/auth-popout-window"; import LockedVaultPendingNotificationsItem from "../autofill/notification/models/locked-vault-pending-notifications-item"; import { AutofillService } from "../autofill/services/abstractions/autofill.service"; +import { AutofillOverlayVisibility } from "../autofill/utils/autofill-overlay.enum"; import { BrowserApi } from "../platform/browser/browser-api"; import { BrowserStateService } from "../platform/services/abstractions/browser-state.service"; import { BrowserEnvironmentService } from "../platform/services/browser-environment.service"; @@ -43,6 +45,7 @@ export default class RuntimeBackground { private logService: LogService, private configService: ConfigServiceAbstraction, private fido2Service: Fido2Service, + private settingsService: SettingsService, ) { // onInstalled listener must be wired up before anything else, so we do it in the ctor chrome.runtime.onInstalled.addListener((details: any) => { @@ -325,6 +328,9 @@ export default class RuntimeBackground { if (this.onInstalledReason != null) { if (this.onInstalledReason === "install") { BrowserApi.createNewTab("https://bitwarden.com/browser-start/"); + await this.settingsService.setAutoFillOverlayVisibility( + AutofillOverlayVisibility.OnFieldFocus, + ); if (await this.environmentService.hasManagedEnvironment()) { await this.environmentService.setUrlsToManagedEnvironment();